Pin the Vite+ toolchain (deterministic oxfmt) + refresh deps#204
Merged
Conversation
The catalog used vite: @voidzero-dev/vite-plus-core@latest, so every install could re-resolve a different vite-plus-core — and its bundled oxfmt then formatted the same file differently between local and CI (e.g. the preview-card alignment PR). Pin vite-plus-core and vite-plus to 0.2.1 so the toolchain (and the formatter) is deterministic everywhere, and refresh the lockfile. check + build are clean; CI runs the browser test suite.
|
📚 Storybook preview: https://pr-204-propel-storybook.vamsi-906.workers.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands first; the alignment PRs (#162–#203) rebase onto this so their formatting becomes reproducible.
Why
The catalog pinned the toolchain as
vite: npm:@voidzero-dev/vite-plus-core@latest. Becauseoxfmtships insidevite-plus-core, everyvp installcould re-resolve a differentoxfmt— so the same file formatted differently between a local checkout and CI (and between branches whose worktree installs re-resolved@latestat different times). That left a couple of alignment PRs red on a formatting nit no localvp checkcould reproduce.Change
vite→npm:@voidzero-dev/vite-plus-core@0.2.1(was@latest) andvite-plus→0.2.1, so the toolchain — and the bundledoxfmt— is deterministic for everyone.Verification
vp checkclean (all files correctly formatted under pinned 0.2.1).vp run buildclean (attw + publint pass).Follow-up
Once merged, rebase the alignment branches onto
mainand re-runvp check --fixper branch — formatting is then reproducible and the format-drift reds clear.