Skip to content

[WEB-7888] fix(security): normalize href before protocol check in CustomLinkExtension (GHSA-v2vv-7wq3-8w2j) #9313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mguptahub wants to merge 2 commits into
base: preview
Choose a base branch
from
+10 −0
Open

[WEB-7888] fix(security): normalize href before protocol check in CustomLinkExtension (GHSA-v2vv-7wq3-8w2j) #9313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3387e24
[WEB-7888] fix(security): normalize href before protocol check in Cus…
mguptahub Jun 25, 2026
d333d2c
[WEB-7888] fix: align clickHandler blocked-scheme list with isValidHt…
mguptahub Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified packages/editor/src/core/extensions/custom-link/extension.tsx
View file
Open in desktop
Binary file not shown.
10 changes: 10 additions & 0 deletions packages/editor/src/core/extensions/custom-link/helpers/clickHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,16 @@ export function clickHandler(options: ClickHandlerOptions): Plugin {
const target = link?.target ?? attrs.target;

if (link && href) {
// Defence-in-depth: link.href is the browser-resolved URL (whitespace
// already stripped by the browser's WHATWG URL parser), so a protocol
// check here is sufficient to catch any dangerous URI that slipped past
// the editor's parse/render-time guards. Matches the blocked-scheme list
// in isValidHttpUrl (javascript:, data:, vbscript:, file:, about:)
// to keep the policy consistent (GHSA-v2vv-7wq3-8w2j).
if (/^(javascript|data|vbscript|file|about):/i.test(href)) {
return false;
}

window.open(href, target);

return true;
Expand Down
Loading