fix: verify header API key against Plane API#157
Draft
sriramveeraghanta wants to merge 1 commit into
Draft
Conversation
PlaneHeaderAuthProvider previously trusted any x-api-key header without validation, only logging that a key was present. This verifies the key by calling /api/v1/users/me/ on the Plane API and rejecting the token if the request does not return 200. - Resolve base URL from PLANE_INTERNAL_BASE_URL / PLANE_BASE_URL (default https://api.plane.so) for server-to-server verification. - Add configurable request timeout (default 10s). - Handle httpx.RequestError by failing closed (return None).
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlaneHeaderAuthProviderpreviously accepted anyx-api-keyheader without validating it — it only logged that a key was present and immediately issued anAccessToken. This means an invalid or revoked key would still pass MCP auth.This change verifies the API key against the Plane API before granting access.
Changes
GET /api/v1/users/me/with the suppliedx-api-key. Reject the token (return None) on any non-200response.PLANE_INTERNAL_BASE_URL, thenPLANE_BASE_URL, defaulting tohttps://api.plane.so— consistent with server-to-server call handling elsewhere.timeout_secondsconstructor arg (default10s).httpx.RequestError(network/timeout) — returnsNonerather than granting access.Notes
RuntimeErrorpath).AccessTokenis still cached for 1h viaexpires_at.🤖 Generated with Claude Code