fix: the only hard coded cluster domain name within plane-ce#249
fix: the only hard coded cluster domain name within plane-ce#249saniyar-dev wants to merge 1 commit into
Conversation
…uding the enterprise chart
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe ChangesChart Version Bump and Configurable Cluster Domain
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Hi guys i wasn't sure that you want to fix the enterprise chart or not, but i was trying to install and use your apps using helm chart to get started with it and then found it this bug along the road. within the ce chart there was only in live config files and secret template that you had hard-coded domain, but there is multiple fixes needed for the enterprise.
not sure that you wanted to bump the chart version or not, but i did bumped it in this PR.
tell me if you want to fix this issue within the enterprise chart too i can extend the commits to that chart too.
Thanks for your time and your great product.
Summary by CodeRabbit