Skip to content

fix: the only hard coded cluster domain name within plane-ce#249

Open
saniyar-dev wants to merge 1 commit into
makeplane:masterfrom
saniyar-dev:bugfix/hard-coded-cluster-domain
Open

fix: the only hard coded cluster domain name within plane-ce#249
saniyar-dev wants to merge 1 commit into
makeplane:masterfrom
saniyar-dev:bugfix/hard-coded-cluster-domain

Conversation

@saniyar-dev

@saniyar-dev saniyar-dev commented Jun 21, 2026

Copy link
Copy Markdown

Hi guys i wasn't sure that you want to fix the enterprise chart or not, but i was trying to install and use your apps using helm chart to get started with it and then found it this bug along the road. within the ce chart there was only in live config files and secret template that you had hard-coded domain, but there is multiple fixes needed for the enterprise.

not sure that you wanted to bump the chart version or not, but i did bumped it in this PR.

tell me if you want to fix this issue within the enterprise chart too i can extend the commits to that chart too.

Thanks for your time and your great product.

Summary by CodeRabbit

  • Chores
    • Bumped Helm chart version from 1.5.1 to 1.5.2
    • Updated environment variable configuration to use a configurable cluster domain for Redis and API endpoints

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f102633b-f506-44d7-b4fe-4a91baa82799

📥 Commits

Reviewing files that changed from the base of the PR and between 728c9d9 and 45b8253.

📒 Files selected for processing (2)
  • charts/plane-ce/Chart.yaml
  • charts/plane-ce/templates/config-secrets/live-env.yaml

Walkthrough

The plane-ce Helm chart version is bumped from 1.5.1 to 1.5.2. In live-env.yaml, the hardcoded cluster.local string in both REDIS_URL and API_BASE_URL is replaced with .Values.env.default_cluster_domain (defaulting to "cluster.local").

Changes

Chart Version Bump and Configurable Cluster Domain

Layer / File(s) Summary
Configurable cluster domain and version bump
charts/plane-ce/templates/config-secrets/live-env.yaml, charts/plane-ce/Chart.yaml
REDIS_URL and API_BASE_URL now use .Values.env.default_cluster_domain (defaulting to "cluster.local") instead of the hardcoded string; chart version incremented to 1.5.2.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • pablohashescobar

Poem

🐇 Hop, hop, no more hardcoded domain!
The cluster speaks its name through values now,
And the chart ticks up with a gentle bow.
default_cluster_domain takes the stage,
A tiny tweak, but a configurable age! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing hardcoded cluster domain names with configurable values in the plane-ce Helm chart.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant