Skip to content

encode/decode enhancement#122

Open
frankobe wants to merge 8 commits into
mailgun:masterfrom
frankobe:aggregate-encode
Open

encode/decode enhancement#122
frankobe wants to merge 8 commits into
mailgun:masterfrom
frankobe:aggregate-encode

Conversation

@frankobe

@frankobe frankobe commented Nov 3, 2016

Copy link
Copy Markdown

Fix 3 encoding/decoding problems during my daily usage of flanker, tests case from real life added

  1. poor support of Chinese encoding including 'gb2312', 'gbk' and 'gb18030'

  2. heavily rely on _guess_and_convert, ignore context-type as demonstrated by test email charset-gb2312.eml

  3. cant handle encode word data corruption caused by encode word separation into multi lines as demonstrated by test case encodedword_test

@mailgun-ci

Copy link
Copy Markdown

Can one of the admins verify this patch?

@frankobe

Copy link
Copy Markdown
Author

wonder is this repo actively maintained?

@frankobe frankobe force-pushed the aggregate-encode branch from 09b414d to 08fc30c Compare June 7, 2017 23:28
@frankobe frankobe force-pushed the aggregate-encode branch from ebc3c3a to 34df5f5 Compare June 9, 2017 21:19
@frankobe frankobe force-pushed the aggregate-encode branch from 4b1f4e8 to 17bacd7 Compare June 9, 2017 21:29
@b0d0nne11

Copy link
Copy Markdown
Contributor

It is still maintained and we're slowly trying to chip away at these older issues. Sorry for letting it languish! If you're still interested could you rebase on master to cleanup the diff and collapse the fix commits?

@frankobe

Copy link
Copy Markdown
Author

@b0d0nne11 sure, I can do it, need some time to rebase my memory though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants