Repository navigation
Re-refactor: fix libbs integration on GUI-based usage - #155
Merged
Merged
Conversation
mahaloz
force-pushed
the
fix/re-refactor-libbs
branch
from
March 27, 2026 04:50
bedcee2 to
4d96cf9
Compare
This reverts commit 036265e.
Uses the new `shortcut` parameter on `gui_register_ctx_menu` (libbs) so the server-start dialog can be triggered without going through the menu. Works across IDA, Binja, and angr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #154
TODO
The following bugs still exist in the refactor that we did not catch in the CI (all headless testcases that do not use GUI)
gui_ask_for_stringcall because we call it on the init of an IDA Plugin, when really it should be called on the trigger of the plugin action (see BinSync proper for example)gui_ask_for_stringin some decompilers (IDA Reported).