chore: relicense under MIT and prepare the 1.0.0 release - #17
Merged
Merged
Conversation
Relicensed from EUPL-1.2 to MIT. Integrating this plugin means subclassing its models and applying its ProductTrait to your own Product, which made the EUPL's reciprocity terms a real question for a commercial shop - a question the plugin has no reason to ask. The LICENSE file also now carries the copyright notice it previously lacked. Every commit in this repository is by the sole copyright holder, so there is no third-party consent to gather. Release preparation: - CHANGELOG: the accumulated [Unreleased] entries become [1.0.0], restructured into single Changed/Added/Fixed sections rather than the two half-merged sets the readiness work left behind. Link reference definitions added, so the version headings stop rendering as literal brackets. - README: the release-candidate banner becomes a stable-release one, and the install line drops the @rc stability flag. - composer.json: package homepage and a support block (issues, source, docs), which Packagist otherwise has to guess at, plus two more keywords. The upgrade note in the changelog is the one thing worth reading before tagging: anyone already running an RC has DoctrineMigrations\Version20260807090000 recorded in sylius_migrations, and the migration is now namespaced Madcoders\SyliusBrandPlugin\Migrations. They must rename the recorded version rather than let the migration re-run, which would fail on CREATE TABLE. Verified on PHP 8.4 against MySQL 8.4: composer validate --strict, PHPStan (level max), ECS, Rector, 48 unit tests, 17 non-unit tests, 26 Behat scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relicenses the plugin under MIT and prepares the 1.0.0 release.
MIT
Integrating this plugin means subclassing its models (
App\Entity\Brand\Brand extends BaseBrand) and applying itsProductTraitto your ownProduct. Under EUPL-1.2 that made the reciprocity terms a real question for a commercial shop - one an integrator's legal team has to answer before adopting, and one this plugin has no reason to ask. Every other package in the ecosystem it sits beside (Sylius itself, the settings plugin) is MIT.LICENSEalso now carries a copyright notice, which it previously lacked entirely - EUPL-1.2 conditions its own application on that notice being present.Every commit in this repository is authored by the sole copyright holder, so there was no third-party consent to gather. I checked before changing anything.
Release preparation
[Unreleased]entries become[1.0.0] - 2026-09-02. They were two half-merged sets left over from the readiness work, with duplicatedChanged/Added/Fixedheadings and an orphaned paragraph; restructured into one section with single headings. Link reference definitions added, so the version headings stop rendering as literal brackets.:^1.0@RCstability flag.homepageand asupportblock (issues, source, docs), which Packagist otherwise guesses at, plussylius2andecommercekeywords.Upgrade note, worth reading before the tag goes out
Anyone already running an RC has
DoctrineMigrations\Version20260807090000recorded insylius_migrations. The migration is now namespacedMadcoders\SyliusBrandPlugin\Migrations(#1), so on those installs it looks like a new migration and will re-run, failing onCREATE TABLE. They need to rename the recorded version rather than let it run:This is in the changelog. It only affects RC installs; a fresh install is unaffected.
Verification
PHP 8.4.22 against MySQL 8.4:
composer validate --strict, PHPStan (level: max), ECS, Rector, 48 unit tests, 17 non-unit tests, 26 Behat scenarios / 213 steps. No EUPL reference remains anywhere except the changelog entry describing the change.After merging
The
v1.0.0tag goes on the merge commit. The docs PR (#15) stays open and still needs its refresh.