Silence sqlglot warnings from internal sub-parser body re-rendering#625
Merged
Merged
Conversation
NestedResolver._body_sql re-renders subquery bodies via sqlglot's generator and feeds the result to a sub-Parser. Because the generator defaulted to ErrorLevel.WARN, unsupported-feature warnings (e.g. T-SQL FOR XML PATH) leaked to end users even though the regenerated SQL is purely internal. Switch to ErrorLevel.IGNORE — same rationale as the existing parse-side silencing in DialectParser._parse_with_dialect. Resolves macbre#261.
macbre
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NestedResolver._body_sqlre-renders subquery bodies via sqlglot's generator and feeds the result to a sub-Parser. The generator defaulted toErrorLevel.WARN, so unsupported-feature warnings (e.g. T-SQLFOR XML PATH) leaked to end users even though the regenerated SQL is internal-only.ErrorLevel.IGNORE— mirrors the existing parse-side silencing inDialectParser._parse_with_dialect.sqlglotlogger emits no warnings duringParser(...).columns.Resolves #261.
Test plan
poetry run pytest -vv --cov=sql_metadata --cov-report=term-missing— 267 passed, 100% coveragepoetry run mypy sql_metadata— cleanpoetry run ruff check sql_metadata— clean🤖 Generated with Claude Code