Don't cache HTTPS responses that have no handshake - #9395
Open
iVamsi wants to merge 13 commits into
Open
Conversation
Reject HTTPS responses with null handshake in Cache.put() and Cache.update() so malformed entries are never written to disk.
iVamsi
changed the title
yschimke
reviewed
Apr 5, 2026
yschimke
reviewed
Apr 5, 2026
Collaborator
|
@swankjesse do we agree that the result should be skipping caching when there isn't a valid handshake? I'm not certain that this would be expected. or if we should allow for this, maybe with some sentinel NoHandshake handshake? |
Contributor
Author
|
@swankjesse @yschimke, are any other changes needed to merge this PR? |
iVamsi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTPS cache entries always include TLS session data. If the handshake is missing — a network interceptor stripped it, or
cacheUrlOverrideturned an HTTP URL into HTTPS — we cannot write a readable entry.#9345 prevented the NPE crash in
writeTo(), but still wrote unreadable/malformed entries to disk. This skips the write input()andupdate().Follow-up to #9345 / #8962