builder/unix: check out SDL release-2.32.8 to fix macOS builds on current Xcode CLT - #605
Open
bitcoin3us wants to merge 1 commit into
Open
builder/unix: check out SDL release-2.32.8 to fix macOS builds on current Xcode CLT#605bitcoin3us wants to merge 1 commit into
bitcoin3us wants to merge 1 commit into
Conversation
SDL 2.30.2 no longer compiles on macOS with current Xcode Command Line
Tools (macOS 26 SDK): with SDL_OPENGL=OFF, SDL_cocoawindow.m messages
the forward-declared SDLOpenGLContext in windowDidChangeScreen:, and
newer clang promotes 'receiver type for instance message is a forward
declaration' to a hard error:
src/video/cocoa/SDL_cocoawindow.m:938:14: error: receiver type
'SDLOpenGLContext' for instance message is a forward declaration
Upstream SDL fixed this on the SDL2 maintenance line in libsdl-org/SDL
commit 0b6eff41 ('Fixed building on macOS with OpenGL disabled'),
first released in 2.32.0; the frozen 2.30.x branch never received it.
Check out release-2.32.8 (bugfix-only continuation of the SDL2 line),
fetching tags first for clones that predate the tag.
Verified: 'build_mpos.sh macOS' fails at the above error with 2.30.2
and builds cleanly with 2.32.8 on macOS 26 CLT; the resulting binary
boots MicroPythonOS and runs apps normally.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
(cherry picked from commit 2e19d68)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #601.
builder/unix.pyforce-checks-out SDLrelease-2.30.2on every unix/macOS build. SDL 2.30.2 no longer compiles on macOS with current Xcode Command Line Tools:The SDL build runs with
SDL_OPENGL=OFF, soSDLOpenGLContext's@interface(guarded bySDL_VIDEO_OPENGL_CGL) is never seen — only the@classforward declaration — andwindowDidChangeScreen:messages it unguarded. Older clang warned; the current CLT makes it a hard error, so any Mac with up-to-date tools can no longer build the desktop binary.Upstream SDL fixed exactly this on the SDL2 maintenance line (libsdl-org/SDL@0b6eff41, "Fixed building on macOS with OpenGL disabled", first in 2.32.0). This moves the checkout to
release-2.32.8, with agit fetch --tagsfallback for clones that predate the tag. Verified: macOS desktop build succeeds with 2.32.8 where 2.30.2 fails; Linux unaffected beyond the tag change.🤖 Generated with Claude Code