Repository navigation
Fix mac ci - #534
Merged
Merged
Fix mac ci#534
Conversation
…-15-intel) jobs macos-13 was retired by GitHub in December 2025. macos-latest is now Apple Silicon, and the prebuilt qgis-deps tarball is x86_64-only, so the arm64 job installs dependencies from Homebrew instead. The Intel job keeps qgis-deps on the transitional macos-15-intel label (supported until August 2027). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…uction The 2x2 system solved per adjacent-face pair divides by the cross product of the two unit face normals. For exactly parallel faces x86 evaluates it to 0.0 and the exact-zero guard skips them, but on arm64 FMA contraction leaves a ~1e-17 residual, so the division injected values up to 1.7e6 into the velocity datasets. Use a tolerance instead: the determinant is the sine of the angle between the faces, so anything below 1e-8 is degenerate regardless of floating-point mode. Also drop the temporary DIAG output used to track this down on CI. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
wonder-sk
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the macos workflow.
macos-13runners are retired, so replaced the existing job to usemacos-15-intelinstead, which shall live until late 2027.A new
osx_tests_arm64job was added usingmacos-latest.This surfaced an issue with a test due to cpu arch change which is also fixed.