fix: use require_relative in exe/ea#15
Merged
Merged
Conversation
Per project convention: executables use require_relative for the initial library load instead of bare require. require_relative ../lib/ea ensures ea.rb (and its autoload entries) loads regardless of gem activation state.
Three CI-breaking sibling-path dependencies in specs:
1. exe/ea: require_relative "../lib/ea" (was require "ea" — autoloads
for Ea::Transformations weren't registered without the initial
require).
2. spec/ea/transformations/parsers/xmi_parser_spec.rb: changed
../../../../lutaml-uml/examples/xmi/basic.xmi → fixtures_path("basic.xmi").
The plateau XMI reference now has a skip guard.
3. spec/ea/diagram/svg_accuracy_spec.rb: added before(:all) skip guard
for the sibling lutaml-uml reference SVG directory.
4. spec/ea/transformations/end_to_end_parsing_spec.rb: changed
../../../../lutaml-uml/examples/xmi/basic.xmi → local fixture path.
With lutaml-uml 0.5.1 on rubygems + ea gemspec pinned ~> 0.5, CI
should resolve all deps from rubygems and pass cleanly.
Suite: 2036 examples, 0 failures, 37 pending (unchanged).
Ruby 4.0 removed 'benchmark' from default gems. lib/ea/qea/benchmark.rb requires it. Add as explicit runtime dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change
require "ea"torequire_relative "../lib/ea"inexe/ea, per project convention.Verification
bundle exec rspec: 2036 examples, 0 failures, 37 pendingea version: 0.2.1ea spa plateau.qea -o out.html: 3.75 MB SPA generated successfully