feat(openid4vci): require key attestation and pin a live wallet proof - #180
Merged
Merged
Conversation
An issuer that publishes key_attestations_required can now refuse a missing header before crypto and before the nonce is spent (#178). Pin a key proof captured from eudi-lib-jvm-openid4vci-kt 0.12.2 (#147) and bump the SD-JWT VC pin to draft-18 with an aka_vcts shape check (#179). expected_vct stays an exact pin. Closes #147 Closes #178 Closes #179
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three things that were unblocked without an external gate.
require_key_attestation=(#178)verify_credential_request_proofs(..., require_key_attestation=True)refuses aproof whose header has no
key_attestationwith the structure rules — beforethe signature and before
check_nonce. An issuer that publisheskey_attestations_requiredno longer burns a single-use nonce on everywallet that forgot to attest (OID4VCI §8.3.1 retry loop). Default
False.JVM-wallet key proof (#147)
Vendors
tests/fixtures/openid4vci/real/eudi-jvm-wallet-key-proof.jwt,captured 2026-07-29 from
eudi-lib-jvm-openid4vci-kt0.12.2 (the library theEUDI Android wallet speaks through) via the downstream issuer's
wallet-harness. Header is
{alg, typ, kid: "0", key_attestation}with nojwk. Verifies end to end with the clock frozen to its owniat. Provenanceis sha256-enforced. A phone session against production is still the
downstream issuer's #182; it is not this issue's remaining gap.
SD-JWT VC draft-18 (#179)
Pin bump from draft-17. Type Metadata §4 is unchanged. When
aka_vctsispresent it must be a non-empty array of non-empty strings that does not
contain
vct.expected_vctis not widened to match an alias.#127 (RFC cite-swap) stays open. W3C REC errata registers re-checked
2026-08-14: all empty.
Closes #147
Closes #178
Closes #179