security(ebsi): pin TIR attributes and href to the listing origin - #173
Merged
Conversation
links.next already refused a port change on an allow-listed host. The attributes URL and each revision href did not. Closes #172
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EBSI HTTP client allow-list matches hostname, not port. Pagination
links.nextis already pinned toscheme://host:port. The two HATEOAS hops that motivated that allow-list were not:attributesand eachhrefwere fetched as-is, so a compromised registry body could GEThttps://api-pilot.ebsi.eu:9200/….attributesoff the listing origin is nowMalformedRegistryResponse. Off-originhrefs are skipped (not fetched).Closes #172
Verified:
bash .claude/skills/ship-issue/scripts/gate.sh.