security(cose): reject non-integer crit labels as CoseMalformed - #171
Merged
Conversation
An array or map as a crit entry is legal CBOR and unhashable, so `lbl not in frozenset` raised TypeError before any crypto. Closes #170
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_reject_unhandled_crittestedlbl not in frozenset({1, 33}). A CBOR array or map as acritentry is a legal decoded value and is unhashable, soparse_sign1raisedTypeError— not anOpenvcError.mdoconly re-wrapsCoseError, so a DeviceResponse can put this inIssuerAuthprotected headers and escapeexcept OpenvcError(I14).Every
critlabel must now be a non-boolintbefore the membership test.Closes #170
Verified:
bash .claude/skills/ship-issue/scripts/gate.sh.