security(wrprc): refuse a missing format instead of matching None - #164
Merged
Conversation
Missing, blank or non-string formats on both the WRPRC entry and the DCQL query used to become None and match each other. An absent format is now a failure, never a match. Closes #161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_str_or_noneturned missing/blank/non-string formats intoNone, andc.format == fmtthen matchedNone == None— a second grant bucket next to well-formed entries. Same fail-open class #89 already closed for WRPAC identifiers.A query without a string
formatis now refused. A registered entry whoseformatis missing never matches.Closes #161
Verified:
bash .claude/skills/ship-issue/scripts/gate.sh(flake8, mypy, pytest 1644 passed / coverage 91%, build+twine).