[src] Integrate DVPlan tool commands#142
Open
martin-velay wants to merge 2 commits intolowRISC:masterfrom
Open
[src] Integrate DVPlan tool commands#142martin-velay wants to merge 2 commits intolowRISC:masterfrom
martin-velay wants to merge 2 commits intolowRISC:masterfrom
Conversation
martin-velay
commented
Apr 2, 2026
- Integrate DVPlan subcommands. These commands will be run only if:
- DVPlan tool is available
- Coverage is enabled
- A "".vplan" file is found in the cuurent sim_cfg.hjson file
- When the condition are met, at the end the regression/simulation, the DVPlan tool will:
- Check the coverage of the specification
- Generate a derived vPlan in the simulation directory
- Perform back-annotation of the vPlan with the coverage data
- Compute the coverage of the vPlan
- Generate a report based on obtained annotated vPlan
fd95bec to
570f42a
Compare
bc457b5 to
3fbb934
Compare
Collaborator
|
Looks like there is a Ruff lint issue? |
3fbb934 to
3fdee95
Compare
9217e2b to
2f6d26f
Compare
Author
|
Hi, I have rebased on the master. Can you review my PR? |
machshev
reviewed
Apr 21, 2026
Collaborator
machshev
left a comment
There was a problem hiding this comment.
Thanks @martin-velay! Generally looks good, just a few things to tidy up ideally. It would really help to clean up the code if we can get these changes in.
The existing implementation of some of these parts of the code are already a bit of a mess, so this is a good opportunity to start putting in some better examples.
dbbde97 to
4348588
Compare
machshev
reviewed
Apr 21, 2026
machshev
reviewed
Apr 21, 2026
machshev
reviewed
Apr 21, 2026
machshev
reviewed
Apr 21, 2026
4348588 to
1870b83
Compare
1870b83 to
6d79d00
Compare
- Integrate DVPlan subcommands. These commands will be run only if:
- DVPlan tool is available
- Coverage is enabled
- A "".vplan" file is found in the cuurent sim_cfg.hjson file
- When the condition are met, at the end the regression/simulation, the
DVPlan tool will:
- Check the coverage of the specification
- Generate a derived vPlan in the simulation directory
- Perform back-annotation of the vPlan with the coverage data
- Compute the coverage of the vPlan
- Generate a report based on obtained annotated vPlan
Signed-off-by: martin-velay <mvelay@lowrisc.org>
Signed-off-by: martin-velay <mvelay@lowrisc.org>
6d79d00 to
c48e69e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.