Skip to content

[src] Integrate DVPlan tool commands#142

Open
martin-velay wants to merge 2 commits intolowRISC:masterfrom
martin-velay:dvplan_integ
Open

[src] Integrate DVPlan tool commands#142
martin-velay wants to merge 2 commits intolowRISC:masterfrom
martin-velay:dvplan_integ

Conversation

@martin-velay
Copy link
Copy Markdown

  • Integrate DVPlan subcommands. These commands will be run only if:
    • DVPlan tool is available
    • Coverage is enabled
    • A "".vplan" file is found in the cuurent sim_cfg.hjson file
  • When the condition are met, at the end the regression/simulation, the DVPlan tool will:
    • Check the coverage of the specification
    • Generate a derived vPlan in the simulation directory
    • Perform back-annotation of the vPlan with the coverage data
    • Compute the coverage of the vPlan
    • Generate a report based on obtained annotated vPlan

@martin-velay martin-velay force-pushed the dvplan_integ branch 2 times, most recently from fd95bec to 570f42a Compare April 2, 2026 13:27
@martin-velay martin-velay force-pushed the dvplan_integ branch 3 times, most recently from bc457b5 to 3fbb934 Compare April 2, 2026 14:53
@machshev
Copy link
Copy Markdown
Collaborator

machshev commented Apr 6, 2026

Looks like there is a Ruff lint issue?

@martin-velay martin-velay marked this pull request as ready for review April 9, 2026 09:46
@martin-velay martin-velay force-pushed the dvplan_integ branch 2 times, most recently from 9217e2b to 2f6d26f Compare April 13, 2026 16:49
@martin-velay
Copy link
Copy Markdown
Author

Hi, I have rebased on the master. Can you review my PR?

Copy link
Copy Markdown
Collaborator

@machshev machshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martin-velay! Generally looks good, just a few things to tidy up ideally. It would really help to clean up the code if we can get these changes in.
The existing implementation of some of these parts of the code are already a bit of a mess, so this is a good opportunity to start putting in some better examples.

Comment thread src/dvsim/job/deploy.py Outdated
Comment thread src/dvsim/job/deploy.py Outdated
Comment thread src/dvsim/sim/tool/base.py Outdated
Comment thread src/dvsim/sim/tool/base.py Outdated
Comment thread src/dvsim/sim/tool/base.py Outdated
Comment thread src/dvsim/sim/data.py
Comment thread src/dvsim/sim/flow.py
Comment thread src/dvsim/sim/flow.py Outdated
Comment thread src/dvsim/sim/flow.py
Comment thread src/dvsim/sim/flow.py Outdated
@martin-velay martin-velay force-pushed the dvplan_integ branch 2 times, most recently from dbbde97 to 4348588 Compare April 21, 2026 13:43
Comment thread src/dvsim/job/deploy.py Outdated
Comment thread src/dvsim/sim/tool/base.py Outdated
Comment thread src/dvsim/sim/tool/vcs.py Outdated
Comment thread src/dvsim/sim/tool/xcelium.py Outdated
Copy link
Copy Markdown
Collaborator

@machshev machshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martin-velay

- Integrate DVPlan subcommands. These commands will be run only if:
    - DVPlan tool is available
    - Coverage is enabled
    - A "".vplan" file is found in the cuurent sim_cfg.hjson file
- When the condition are met, at the end the regression/simulation, the
  DVPlan tool will:
    - Check the coverage of the specification
    - Generate a derived vPlan in the simulation directory
    - Perform back-annotation of the vPlan with the coverage data
    - Compute the coverage of the vPlan
    - Generate a report based on obtained annotated vPlan

Signed-off-by: martin-velay <mvelay@lowrisc.org>
Signed-off-by: martin-velay <mvelay@lowrisc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants