Repository navigation
feat(help): show custom keybindings in the help popup - #36
Merged
Merged
Conversation
The `?` popup printed the built-in keys from a hard-coded table, so a `[keybindings]` override reached the footer but not the popup. Each action's row now asks the active keymap for its labels, and a custom binding wins over the built-in — the same choice `display_key` already makes for the footer. Keys the keymap does not own (preview scrolling, `Esc`, `:!` / `:term`) stay literal, and `dd` / the cursor pair stay curated because the live form would misrepresent a double press or reorder an interleaved pair. Refs #34
The help-popup keybinding fix, version bumped and the man page regenerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
?help popup printed the built-in keys from a hard-coded table, so a[keybindings]override reached the footer but not the popup.Refs #34