Add TDD calculation for Loop users and Basal Variability chart#640
Open
MtlPhil wants to merge 1 commit intoloopandlearn:devfrom
Open
Add TDD calculation for Loop users and Basal Variability chart#640MtlPhil wants to merge 1 commit intoloopandlearn:devfrom
MtlPhil wants to merge 1 commit intoloopandlearn:devfrom
Conversation
- Add TDD (Total Daily Dose) calculation for Loop from device status and treatments, including basal gap fill, race condition handling, and crash fix on empty basalData - Add Basal Variability chart to Statistics view - Fix TDD double-count: compute only from treatments, not device status - Fix TDD blank on first load due to device status / treatments race condition https://claude.ai/code/session_01DGCES9o6CLpeAmfe7tMoR6
Contributor
Author
|
Corrected lint errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feat: TDD calculation for Loop and Basal Variability chart
Summary
Two additions to the Statistics view for Loop users, plus a set of correctness fixes for the underlying TDD data pipeline.
1. TDD (Total Daily Dose) calculation for Loop
Displays the rolling 24-hour total daily dose in the info table for Loop users. TDD is computed from the
treatmentsendpoint only (not device status) to avoid double-counting, then cached toStorageso it is available across views.Data pipeline
The calculation lives in
DeviceStatusLoopand runs whenever treatments or device status are refreshed:treatments(normal + SMB).Treatments.swiftnow posts a.treatmentsUpdatednotification thatDeviceStatusLoopobserves, ensuring TDD is not computed until both datasets are available.Fixes included
.treatmentsUpdatedbefore first calculationbasalDatabasalData.firstbefore accessing it2. Basal Variability chart
A new chart in the Statistics view that plots scheduled vs. actual basal delivery over the selected date range, making it easy to see how often and by how much Loop is adjusting basal.
New files
LoopFollow/Stats/BasalVariability/BasalVariabilityCalculator.swiftLoopFollow/Stats/BasalVariability/BasalVariabilityDataPoint.swiftLoopFollow/Stats/BasalVariability/BasalVariabilityGraphView.swiftLoopFollow/Stats/BasalVariability/BasalVariabilityView.swiftLoopFollow/Stats/BasalVariability/BasalVariabilityViewModel.swiftAggregatedStatsViewModelThe chart is gated behind Loop being the active closed-loop system and is inserted into
AggregatedStatsViewbetween the TIR section and the existing tables.Files changed
LoopFollow/Controllers/Nightscout/DeviceStatus.swiftLoopFollow/Controllers/Nightscout/DeviceStatusLoop.swiftLoopFollow/Controllers/Nightscout/Treatments.swift.treatmentsUpdatednotificationLoopFollow/Stats/AggregatedStatsView.swiftLoopFollow/Stats/AggregatedStatsViewModel.swiftBasalVariabilityViewModelLoopFollow/Stats/BasalVariability/