Conversation
- No need to unmarshal every tx multiple times to figure out if it's an EVM tx or not before it hits Call/DeployTxHandler. - New tx handlers always set TxHandlerResult.Info as soon as they figure out the tx type, legacy handlers didn't do so if the tx failed. - Cleaned up error handling a bit.
pathornteng
reviewed
Oct 2, 2019
pathornteng
left a comment
pathornteng
left a comment
Contributor
There was a problem hiding this comment.
So after we activate the config, EvmTx is not going to run with loomchain.NoopTxHandler on CheckTx anymore. Need to think about how this would affect receipts and other things.
Contributor
Author
It won't affect receipts and other things because the new |
pathornteng
reviewed
Oct 3, 2019
pathornteng
left a comment
pathornteng
left a comment
Contributor
There was a problem hiding this comment.
We should also enable some e2e test for this router to make sure that it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
loomnetwork/go-loom#478