Skip to content

Crash during marshaling #260

Description

@coinsandsteeldev

One of my methods returned nil pointer with type pb.Message. As it turned out reflection magic makes it "legit" interface pointer with 0 value. Nil check here happens to be valid.

There are 2 ways:

  1. Make sure that nobody returns nil messages.
  2. Make it actually work

I prefer 2nd solution and here is the fix,

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions