Repository navigation
deps: pin datascript-ocaml to 67f10f2 (main moved Int → Int64) - #25
Merged
Merged
Conversation
datascript-ocaml main merged c39cad1/e439cba (value Int of int -> Int64 of int64) between e2e runs, breaking the shared/native build with 'Unbound constructor Ds.Int'. The vendored copy comes from the CI clone loop reading this pin, so #main floats at vendor time. Pin the SHA the last green run vendored; adapting call sites to Int64 is follow-up work.
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin
datascript-ocamlto67f10f2instead of#main. Upstream mergedc39cad1/e439cba(valueInt of int→Int64 of int64) between two e2e runs; the vendored copy comes from the CI clone loop reading this pin, so#mainfloats at vendor time and broke the shared/native build withUnbound constructor Ds.Inton both workflows after the e2e merge.Adapting
Ds.Intcall sites (~105 inshared/src/logseq_chat/core/) toDs.Int64is follow-up work; this restores a green, deterministic main first.dune build @shared/native/runtestpasses locally against67f10f2.Link to Devin session: https://app.devin.ai/sessions/9a91e201984a4d4f96ce3e0f86ac6668
Open in Devin Desktop: https://app.devin.ai/desktop/session/9a91e201984a4d4f96ce3e0f86ac6668?variant=devin
Requested by: @tiensonqin