restore composer + sidebar toggle to pre-port design (and e2e fixes) - #24
Merged
Merged
Conversation
…card Two behaviors dropped in the OCaml port vs the previous LG design: the asset strip scrolled vertically (missing :orientation), and tapping the expanded composer card no longer focused the field (missing on-press -> FocusComposer; containers have no ~on_press in the typed DSL so a with_press helper registers PressEnabled).
…xtarea The header sidebar button lost its ~44pt circle when lui c90fe35 dropped the iOS default 44pt button height (system metrics is intentional — pin the hit target explicitly instead). Also pins lui to 079b13b which keeps .textarea borderless, restoring the composer's bare text field on the glass card.
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
- Apple overflow menu: drop the gear shortcut shown when only settings is visible; always render the previous horizontal-ellipsis menu. - FocusComposer toggles composer_autofocus so every request emits an autofocus prop edge (the flag could already read true while the field was unfocused, producing no diff and no refocus).
devin-ai-integration
Bot
changed the title
…oser-sidebar-restore # Conflicts: # apple/Package.swift # flutter/pubspec.lock # flutter/pubspec.yaml # logseq_chat.opam
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the composer and sidebar toggle to the pre-port design (verified against
b4d1ffdside-by-side on the iOS simulator), reverts the top-right header button back to "···", and fixesFocusComposerrefocus.~orientation:horizontal(it wrapped vertically); restored. The expanded card lost tap-to-focus —with_pressnow emitspress-enabledon the column so tapping the card sendsFocusComposer(lui side: columns acceptpress-enabled`, see apple: keep textarea borderless + e2e fixes (semantics refresh, autofocus edge, hoisted toolbar id) lui#52). The textarea's stray border comes from the lui pin — fixed there.FocusComposernow togglescomposer_autofocus(not current.composer_autofocus) so every press emits a wire diff — prop dedup meant a second focus request while the flag was alreadytrueproduced nothing. Hosts treat any transition as a focus edge (lui#52). Regression testcomposer-refocus-always-emits-an-autofocus-edgeadded.settingsVisible && !pageActionsVisiblegear branch inLGChatOverflowMenu.swift— always back to the "···" menu.af6b2b6— includes the flutter semantics-refresh fix (androidbutton.sidebare2e) and the hoisted-toolbar identifier fix (iostoolbar.outliner.editore2e), both root-caused in apple: keep textarea borderless + e2e fixes (semantics refresh, autofocus edge, hoisted toolbar id) lui#52.Link to Devin session: https://app.devin.ai/sessions/eab2eca00a5649d09fcf48626d9f09ef
Open in Devin Desktop: https://app.devin.ai/desktop/session/eab2eca00a5649d09fcf48626d9f09ef?variant=devin
Requested by: @tiensonqin