Skip to content

Hoist outliner toolbars into the bottom bar and bump lui for Duo layout - #16

Merged
tiensonqin merged 5 commits into
mainfrom
devin/1790287321-duo-bottom-bars
Sep 24, 2026
Merged

tiensonqin merged 5 commits into
mainfrom
devin/1790287321-duo-bottom-bars

Conversation

@tiensonqin

Copy link
Copy Markdown
Contributor

Summary

iPhone Duo adaptation, part 2: the outliner selection and editor toolbars now hoist into the real .bottomBar via ~placement:"bottom", so iOS 27.1 relocates them into the vertical side bar on the unfolded inner display — matching Apple's guidance that bottom toolbars move to the sidebar on Duo. On iOS <27.1 they render in the standard bottom bar; on macOS and Flutter placement:"bottom" falls back to inline rendering, so nothing changes there.

The wide bottom chrome (composer, capture, search) intentionally stays inline — per Apple, wide controls remain in place on Duo; only toolbar/tab-bar items relocate.

The header needs no change: the extension already mounts the sidebar button, title, sync, and connection status into native ToolbarItem/ToolbarItemGroup placements, which adapt automatically.

Depends on the two open lui PRs (both pinned here by commit):

Bumps apple/Package.swift to the drawer-PR head (0e491ba) and logseq_chat.opam to the placement-PR head (e2d35db). Both commits are on the remote and fetchable; re-pin to main after the lui PRs merge.

Validated: dune build @shared/native/runtest — 707 tests green.

Link to Devin session: https://app.devin.ai/sessions/daf154855d664a4e9a456877e847d185
Open in Devin Desktop: https://app.devin.ai/desktop/session/daf154855d664a4e9a456877e847d185?variant=devin
Requested by: @tiensonqin

@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/1790287321-duo-bottom-bars branch from 242fb5b to 748b7b5 Compare September 24, 2026 22:41
@tiensonqin
tiensonqin merged commit f963ba1 into main Sep 24, 2026
3 checks passed
@tiensonqin
tiensonqin deleted the devin/1790287321-duo-bottom-bars branch September 24, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant