Repository navigation
Hoist outliner toolbars into the bottom bar and bump lui for Duo layout - #16
Merged
Merged
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
devin-ai-integration
Bot
force-pushed
the
devin/1790287321-duo-bottom-bars
branch
from
September 24, 2026 22:41
242fb5b to
748b7b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iPhone Duo adaptation, part 2: the outliner selection and editor toolbars now hoist into the real
.bottomBarvia~placement:"bottom", so iOS 27.1 relocates them into the vertical side bar on the unfolded inner display — matching Apple's guidance that bottom toolbars move to the sidebar on Duo. On iOS <27.1 they render in the standard bottom bar; on macOS and Flutterplacement:"bottom"falls back to inline rendering, so nothing changes there.The wide bottom chrome (composer, capture, search) intentionally stays inline — per Apple, wide controls remain in place on Duo; only toolbar/tab-bar items relocate.
The header needs no change: the extension already mounts the sidebar button, title, sync, and connection status into native
ToolbarItem/ToolbarItemGroupplacements, which adapt automatically.Depends on the two open lui PRs (both pinned here by commit):
.regularwidth (unfolded Duo / iPad); overlay behavior preserved at.compact.placementprop onLui_elements.toolbar.Bumps
apple/Package.swiftto the drawer-PR head (0e491ba) andlogseq_chat.opamto the placement-PR head (e2d35db). Both commits are on the remote and fetchable; re-pin to main after the lui PRs merge.Validated:
dune build @shared/native/runtest— 707 tests green.Link to Devin session: https://app.devin.ai/sessions/daf154855d664a4e9a456877e847d185
Open in Devin Desktop: https://app.devin.ai/desktop/session/daf154855d664a4e9a456877e847d185?variant=devin
Requested by: @tiensonqin