fix(idl): emit account helper types in deterministic order#232
Open
0x-r4bbit wants to merge 1 commit into
Open
fix(idl): emit account helper types in deterministic order#2320x-r4bbit wants to merge 1 commit into
0x-r4bbit wants to merge 1 commit into
Conversation
`collect_account_types` seeded its BFS queue via a `HashSet`, whose iteration order is randomized per process. The order helper types were discovered — and emitted in the IDL — therefore varied run-to-run, so the same source produced byte-different IDL. Use order-preserving dedup and sort the returned helper types by name, so output is byte-stable and independent of source declaration order. This is shared by both the CLI and proc-macro paths. Add a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collect_account_typesseeded its BFS queue via aHashSet, whose iteration order is randomized per process. The order helper types were discovered — and emitted in the IDL — therefore varied run-to-run, so the same source produced byte-different IDL.Use order-preserving dedup and sort the returned helper types by name, so output is byte-stable and independent of source declaration order. This is shared by both the CLI and proc-macro paths. Add a regression test.