Fix Speak.activity Enter key repeat playback#2183
Open
rommeltrejo wants to merge 1 commit into
Open
Conversation
|
@rommeltrejo You’re only supposed to raise a PR once you’ve gotten approval from the maintainer for the issue you raised. |
|
@rommeltrejo close the PR read the contrubution guidlines your are not supposed to raise PR with out maintener approval |
Author
|
@nithinshiju-dev will do, I got too excited to finally fix this issue :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Holding Enter in Speak.activity could trigger repeated playback while speech was already running. After enough repeats, the activity triggers slow downs, or runs out of memory and breaks. On the Sugarizer apps the user sees a blank screen after running out of memory; on the browser try-it site Chrome/Edge will ask the user to reload the page.
This change makes Enter handling behave more cleanly:
Reproduce
Before
Video
page@31750c6f0a4c96ea1bb7515aea9383a6.webm
While the speech is active the play button is disabled, but it will start playing again when done if the user (my kid) keeps the Enter button pressed.
Issue context
The linked issue should keep the same concrete impact described here:
Closes #2182