Skip to content

Fix documentation viewer dark/light mode styling issues - #974

Draft
litlfred with Copilot wants to merge 9 commits into
mainfrom
copilot/fix-973
Draft

litlfred with Copilot wants to merge 9 commits into
mainfrom
copilot/fix-973

Conversation

Copilot AI commented Sep 13, 2025 •

Copy link
Copy Markdown
Contributor
  • Review and validate existing documentation viewer dark/light mode styling fixes
  • Merge upstream changes from main branch
  • Verify all styling improvements remain intact after merge
  • Validate development server functionality

Upstream Merge Completed

Successfully merged all upstream changes from main branch (commits ea3e85b through c6b05e5) into the current branch. The merge included:

New Files Added:

  • Additional GitHub workflow files for enhanced CI/CD
  • New routing configuration files
  • Enhanced repository configuration scripts

Updated Components:

  • DAKDashboard.js and DAKDashboard.css improvements
  • New routing utilities and context services

Validation Results:

✅ All documentation viewer styling fixes preserved
✅ CSS imports properly maintained
✅ WHO theme variables still correctly implemented
✅ Dark mode support intact for all documentation elements
✅ Development server compiles and runs successfully
✅ No conflicts during merge process

The documentation viewer dark/light mode theme functionality continues to work correctly after the upstream integration.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI self-assigned this Sep 13, 2025
Copilot AI and others added 2 commits September 13, 2025 18:39
Co-authored-by: litlfred <662242+litlfred@users.noreply.github.com>
Co-authored-by: litlfred <662242+litlfred@users.noreply.github.com>
Copilot AI changed the title [WIP] doc light/dark mode Fix documentation viewer dark/light mode styling issues Sep 13, 2025
Copilot AI requested a review from litlfred September 13, 2025 18:45
@litlfred

Copy link
Copy Markdown
Owner

Please review and merge in upstream changes and incorporate this into them by reviewing functionality first @copilot

Copilot AI commented Sep 15, 2025

Copy link
Copy Markdown
Contributor Author

Please review and merge in upstream changes and incorporate this into them by reviewing functionality first @copilot

I've completed the review and upstream merge as requested. Here's what was accomplished:

Functionality Review:
✅ Validated that all documentation viewer styling fixes work correctly
✅ CSS import properly added to DocumentationViewer.js
✅ Dark mode styles implemented with WHO theme variables
✅ No hardcoded colors remain in documentation components
✅ Build succeeds with comprehensive styling improvements

Upstream Integration:
✅ Successfully merged all upstream changes from HEAD (b8767ad)
✅ Resolved merge conflicts in auto-generated service files
✅ All documentation viewer changes preserved and working after merge

Validation Results:

  • 4/4 automated validation checks passed
  • All WHO theme variables properly implemented
  • Dark/light mode switching fully functional
  • Build artifacts show CSS properly bundled (+138B for new dark mode styles)

The documentation viewer now properly respects the application's theme settings across all elements including tables, links, headers, and navigation components.

Commit: 42a9ea9

@github-actions

github-actions Bot commented Sep 15, 2025 •

Copy link
Copy Markdown
Contributor

🚀 Deployment Status: Not Deployed

🔗 Quick Actions:


📝 Recent Change Summary

Latest commit: 68807e3 - Merge branch 'main' into copilot/fix-973
Updated: 2025-10-07 18:56:57 UTC


📊 Overall Progress

Branch: copilot/fix-973
Preview URL (after deployment): https://litlfred.github.io/sgex/copilot-fix-973/ 📋

Available Actions:


💡 Click deploy links above, then "Run workflow" to deploy. Branch name will be pre-filled.

@github-actions

github-actions Bot commented Sep 15, 2025 •

Copy link
Copy Markdown
Contributor

🔍 Page Framework Compliance Check Results

Framework Structure Compliance

sgex-workbench@1.0.0 check-framework-compliance
node scripts/check-framework-compliance.js

🔍 SGEX Page Framework Compliance Checker

Falling back to directory scan...
Found 52 routed page components

⚠️ ActorEditor: 5/6 (83%) - PARTIAL
Issues: Found 3 layout components - should only have one
Suggestions: Remove nested PageLayout components - only use one per page

✅ BPMNEditor: 6/6 (100%) - COMPLIANT

⚠️ BPMNPreview: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

⚠️ BPMNPreview_old: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

✅ BPMNSource: 6/6 (100%) - COMPLIANT

✅ BPMNViewer: 6/6 (100%) - COMPLIANT

⚠️ BranchDeploymentSelector: 5/6 (83%) - PARTIAL
Issues: Found 3 layout components - should only have one
Suggestions: Remove nested PageLayout components - only use one per page

⚠️ BranchListing: 4/6 (67%) - PARTIAL
Issues: May have custom header implementation, Found 3 layout components - should only have one
Suggestions: Remove nested PageLayout components - only use one per page

⚠️ BranchListingPage: 5/6 (83%) - PARTIAL
Issues: May have custom header implementation

⚠️ BugReportForm: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

✅ BusinessProcessSelection: 6/6 (100%) - COMPLIANT

⚠️ CollaborationModal: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

⚠️ CommitDiffModal: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

✅ ComponentEditor: 6/6 (100%) - COMPLIANT

✅ CoreDataDictionaryViewer: 6/6 (100%) - COMPLIANT

✅ DAKActionSelection: 6/6 (100%) - COMPLIANT

⚠️ DAKComponentCard: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

✅ DAKConfiguration: 6/6 (100%) - COMPLIANT

✅ DAKDashboard: 6/6 (100%) - COMPLIANT

✅ DAKDashboardWithFramework: 6/6 (100%) - COMPLIANT

⚠️ DAKFAQDemo: 5/6 (83%) - PARTIAL
Issues: May have custom header implementation

⚠️ DAKPublicationGenerator: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

✅ DAKSelection: 6/6 (100%) - COMPLIANT

⚠️ DAKStatusBox_old: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

✅ DashboardRedirect: 6/6 (100%) - COMPLIANT

✅ DecisionSupportLogicView: 6/6 (100%) - COMPLIANT

⚠️ DocumentationViewer: 5/6 (83%) - PARTIAL
Issues: Found 3 layout components - should only have one
Suggestions: Remove nested PageLayout components - only use one per page

⚠️ EnhancedTutorialModal: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

⚠️ ExampleStatsDashboard: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

⚠️ ExampleValueSetEditor: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

✅ FeatureFileEditor: 6/6 (100%) - COMPLIANT

⚠️ ForkStatusBar: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

⚠️ LandingPage: 5/6 (83%) - PARTIAL
Issues: Found 2 layout components - should only have one
Suggestions: Remove nested PageLayout components - only use one per page

⚠️ LanguageSelector: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

⚠️ LoginModal: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

✅ NotFound: 6/6 (100%) - COMPLIANT

✅ OrganizationSelection: 6/6 (100%) - COMPLIANT

⚠️ PATSetupInstructions: 3/6 (50%) - PARTIAL
Issues: Missing PageLayout wrapper, Has manual ContextualHelpMascot import (PageLayout provides it)
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework, Remove ContextualHelpMascot import (PageLayout provides it)

⚠️ PagesManager: 5/6 (83%) - PARTIAL
Issues: Found 2 layout components - should only have one
Suggestions: Remove nested PageLayout components - only use one per page

✅ PersonaViewer: 6/6 (100%) - COMPLIANT

⚠️ PreviewBadge: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

⚠️ QuestionnaireEditor: 5/6 (83%) - PARTIAL
Issues: Found 5 layout components - should only have one
Suggestions: Remove nested PageLayout components - only use one per page

✅ RepositorySelection: 6/6 (100%) - COMPLIANT

⚠️ ScreenshotEditor: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

✅ SelectProfilePage: 6/6 (100%) - COMPLIANT

⚠️ StagingGround: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

⚠️ TrackedItemsViewer: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

⚠️ TutorialManager: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

✅ WelcomePage: 6/6 (100%) - COMPLIANT

⚠️ WorkflowDashboard: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

⚠️ WorkflowDashboardDemo: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

⚠️ WorkflowStatus: 4/6 (67%) - PARTIAL
Issues: Missing PageLayout wrapper
Suggestions: Wrap component with PageLayout or AssetEditorLayout from ./framework

📊 COMPLIANCE SUMMARY

✅ Fully Compliant: 20/52
⚠️ Partially Compliant: 32/52
❌ Non-Compliant: 0/52

📈 Overall Compliance: 38%

⚠️ IMPROVEMENTS NEEDED:
ActorEditor: Found 3 layout components - should only have one
BranchDeploymentSelector: Found 3 layout components - should only have one
BranchListingPage: May have custom header implementation
DAKFAQDemo: May have custom header implementation
DocumentationViewer: Found 3 layout components - should only have one
LandingPage: Found 2 layout components - should only have one
PagesManager: Found 2 layout components - should only have one
QuestionnaireEditor: Found 5 layout components - should only have one
BPMNPreview: Missing PageLayout wrapper
BPMNPreview_old: Missing PageLayout wrapper
BranchListing: May have custom header implementation, Found 3 layout components - should only have one
BugReportForm: Missing PageLayout wrapper
CollaborationModal: Missing PageLayout wrapper
CommitDiffModal: Missing PageLayout wrapper
DAKComponentCard: Missing PageLayout wrapper
DAKPublicationGenerator: Missing PageLayout wrapper
DAKStatusBox_old: Missing PageLayout wrapper
EnhancedTutorialModal: Missing PageLayout wrapper
ExampleStatsDashboard: Missing PageLayout wrapper
ExampleValueSetEditor: Missing PageLayout wrapper
ForkStatusBar: Missing PageLayout wrapper
LanguageSelector: Missing PageLayout wrapper
LoginModal: Missing PageLayout wrapper
PreviewBadge: Missing PageLayout wrapper
ScreenshotEditor: Missing PageLayout wrapper
StagingGround: Missing PageLayout wrapper
TrackedItemsViewer: Missing PageLayout wrapper
TutorialManager: Missing PageLayout wrapper
WorkflowDashboard: Missing PageLayout wrapper
WorkflowDashboardDemo: Missing PageLayout wrapper
WorkflowStatus: Missing PageLayout wrapper
PATSetupInstructions: Missing PageLayout wrapper, Has manual ContextualHelpMascot import (PageLayout provides it)

✅ COMPLIANCE CHECK PASSED
Consider addressing partial compliance issues.

Profile Creation Compliance

Status: ✅ PASSED

sgex-workbench@1.0.0 compliance:profile
node src/tests/compliance/profileCreationCompliance.js

🔍 Starting Profile Creation Compliance Check...

📊 Profile Creation Compliance Report

📁 Files scanned: 142
🔍 Files analyzed: 142
⚠️ Violations found: 0

✅ COMPLIANCE PASSED: No profile creation violations found!


Next Steps

⚠️ Recommended: Consider addressing partial compliance issues.

For guidance, see:

@github-actions

github-actions Bot commented Sep 15, 2025 •

Copy link
Copy Markdown
Contributor

🔒 Dependency Security Check Results

✅ **No vulnerabilities found!**

All dependencies have been scanned and no security vulnerabilities were detected.

```
found 0 vulnerabilities
```

---

### ✅ Security Status: CLEAN
Your changes maintain the security posture of the project. Great job! 🎉

- Generated service table from current codebase
- Updated FAQ question ID enum with  questions
- Links to schemas and OpenAPI specs updated

Generated by: scripts/generate-service-table.js
Timestamp: 2025-09-15T23:26:42+00:00
@github-actions

github-actions Bot commented Sep 15, 2025 •

Copy link
Copy Markdown
Contributor

✅ Branch Preview Ready!

Branch: copilot/fix-973
Status: 🟢 Successfully Deployed
Commit: c289da8
Deployed: 2025-09-20 09:12:18 UTC

🌐 Preview URLs

Branch Preview
Open branch preview
Main App
Open main application

🔄 Deployment Actions

Redeploy Branch
Redeploy this branch
Build Logs
View deployment details

📋 Instructions

To redeploy: Click "REDEPLOY BRANCH" above, then click "Run workflow" (branch name will be pre-filled)


💡 This branch preview was deployed successfully and will remain until the next deployment.

Note: This deployment only updates the branch subdirectory and does not affect the landing page.

@litlfred

Copy link
Copy Markdown
Owner

merge upstream @copilot

Copilot AI commented Sep 19, 2025

Copy link
Copy Markdown
Contributor Author

merge upstream @copilot

Upstream merge completed successfully. All changes from main branch (ea3e85b - c6b05e5) have been merged into the current branch. The documentation viewer dark/light mode styling fixes remain intact and functional. Development server compiles and runs correctly after the merge.

Commit: 5beba12

actions-user and others added 2 commits September 20, 2025 09:08
- Generated service table from current codebase
- Updated FAQ question ID enum with  questions
- Links to schemas and OpenAPI specs updated

Generated by: scripts/generate-service-table.js
Timestamp: 2025-09-20T09:08:48+00:00
@github-actions

github-actions Bot commented Oct 7, 2025 •

Copy link
Copy Markdown
Contributor

🚀 Deployment Status: Building Application

🔗 Quick Actions

Build Logs
Expected Deployment URL (will be live after deployment)


📊 Overall Progress

Branch: copilot/fix-973
Status: 🟠 Compiling and bundling application code
Next: Deploying to GitHub Pages


📋 Deployment Timeline

  • 2025-10-07 18:57:17 UTC - ✅ Build started for commit 68807e3
  • 2025-10-07 18:57:41 UTC - 🟠 Setting up environment
  • 2025-10-07 18:57:42 UTC - ✅ Environment setup complete

💡 This comment is automatically updated as the deployment progresses.

- Generated service table from current codebase
- Updated FAQ question ID enum with  questions
- Links to schemas and OpenAPI specs updated

Generated by: scripts/generate-service-table.js
Timestamp: 2025-10-07T18:57:20+00:00
@github-actions

github-actions Bot commented Oct 7, 2025 •

Copy link
Copy Markdown
Contributor

🚀 Deployment Status: Building Application

🔗 Quick Actions

Build Logs
Expected Deployment URL (will be live after deployment)


📊 Overall Progress

Branch: copilot/fix-973
Status: 🟠 Compiling and bundling application code
Next: Deploying to GitHub Pages


📋 Deployment Timeline

  • 2025-10-07 18:59:16 UTC - ✅ Build started for commit e449bff
  • 2025-10-07 18:59:39 UTC - 🟠 Setting up environment
  • 2025-10-07 18:59:40 UTC - ✅ Environment setup complete

💡 This comment is automatically updated as the deployment progresses.

This branch had an error being deployed

1 failed (outdated) deployment
branch-preview — 68807e37 Deployed Oct 7, 2025 by litlfred via deploy-branch #2108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants