Update to v0.4.9 - #105
Open
lipelopesoliveira wants to merge 86 commits into
Open
Conversation
…te documentation.
…and Qst computations
…tomLennardJones and CustomGNP calculators
…in library for atom overlap checks
…aals overlap detection in GCMC class
…improved performance
…urn a numpy array
…ilibration method
…d improve readability
…for standard deviation calculation
… Vesin package for improved performance
…and improve calculation stability
…r improved flexibility and accuracy in calculations
…ling, improving flexibility and usability
…ended modifications
…asing and simplify structure selection
… initialization and validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description 📝
Changes Proposed 🔧
New Features 🎉
MoveWeightsclass for managing and normalizing movement weights in simulations. This class allows users to define weights for different types of moves (insertion, deletion, translation, rotation, reinsertion, and identity change) and ensures that they are normalized to sum to 1. It also provides a method to select a move based on the defined weights using a random generator.Widomsimulations by setting thesave_only_adsorbateparameter toTruewhen initializing theWidomclass. This feature allows users to save only the positions of the adsorbate molecules during the Widom insertion process, which can be useful for analyzing the behavior of the adsorbates without saving the entire system state. When set toFalse, the full system state will be saved, including both the framework and adsorbate molecules. The default value for this parameter is set toFalse, meaning that the full system state will be saved unless specified otherwise by the user.Enhanced ✨
vesinlibrary to check for atom overlaps during the insertion of adsorbates in the GCMC and Widom simulations. Thevesinlibrary provides a more efficient method for calculating distances, prividing around 10x speedup in the overlap checking process. From the practical point of view, this change should provide only a minor speedup in the overall simulation time, as this process took only 30 ms on average for 2000 atoms, and now takes only 3 ms. However, this change improves the overall efficiency of the code and reduces the computational overhead associated with overlap checking.BaseEOSandPengRobinsonEOSclasses for better reuse.PengRobinsonEOSto compare the results withRASPA2and ensure the accuracy of the calculations. The tests include comparisons of fugacity coefficients and bulk phase densities for different gases at various temperatures and pressures, providing a comprehensive validation of the EOS implementation.Fixed 🐛
shiftedparameter in theCustomLennardJonesandCustomGNPcalculators is set toFalse. This change ensures that the Lennard-Jones and GNP potentials are not shifted by default, which may be more appropriate for certain simulations. Users can still set this parameter toTrueif they wish to apply a shift to the potential.Documentation 📖
CustomLennardJonesandCustomEwaldcalculators in GCMC and Widom simulations have been added to the documentation. These examples demonstrate how to set up and run simulations using these calculators, providing users with practical guidance on their usage.Modified 🛠
️- Moved the
CustomLennardJonesandCustomEwaldcalculators to theflames.calculators.lennard_jonesandflames.calculators.ewaldmodules, respectively. This change improves the organization of the codebase and makes it easier for users to locate and use these calculators in their simulations.LLMparameter in theGCMCclass to thesave_resultsmethod. This change allows users to specify whether to use the Left-most Local Minima (LLM) method for equilibration analysis when saving the results of a GCMC simulation, providing greater flexibility in how the results are analyzed and reported. The default value for this parameter is set toFalse, meaning that the LLM method will not be used by default unless specified otherwise.Removed 🗑️
max_overlap_triesparameter from theGCMCandWidomclasses. This parameter was previously used to limit the number of attempts for placing an adsorbate without van der Waals overlap. However, it may cause problems in the simulation leading to potential issues with sampling.Related Issues 📎
Fixes # <issue_number>
Closes # <issue_number>
Before submitting 📌
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.Testing Instructions 🧪
Additional Notes 💬