Skip to content

fix: don't echo a slash-less path as the login command #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lionello merged 1 commit into from
Aug 5, 2026
Merged

fix: don't echo a slash-less path as the login command #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions bin/onedrive
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,9 +665,22 @@ async function cat(args) {
function commandName() {
const argv1 = process.argv[1] || 'onedrive-cli'
const rel = Path.relative(process.cwd(), argv1)
return rel && !rel.startsWith('..') && !Path.isAbsolute(rel)
? rel
: Path.basename(argv1)
const parts = rel.split(Path.sep)
// Running from a directory *above* us yields a long relative path that
// reads like a mangled absolute one -- from '/' this file becomes
// 'Users/me/dev/onedrive-cli/bin/onedrive', which is neither obviously
// runnable nor something to hand to the landing page. Keep at most one
// leading folder, and fall back to the basename beyond that.
if (
!rel ||
parts.length > 2 ||
rel.startsWith('..') ||
Path.isAbsolute(rel)
) {
return Path.basename(argv1)
}
// A bare name is only runnable as './name'; with a folder it already is.
return parts.length === 1 ? '.' + Path.sep + rel : rel
}

function buildLoginUrl(readonly, state) {
Expand Down