sound settings: Revive overamplication on input.#13714
Open
SyberHexen wants to merge 2 commits intolinuxmint:masterfrom
Open
sound settings: Revive overamplication on input.#13714SyberHexen wants to merge 2 commits intolinuxmint:masterfrom
SyberHexen wants to merge 2 commits intolinuxmint:masterfrom
Conversation
Contributor
|
The switch for Overamplification in sound settings is only in the Output section, so from there it doesn't make sense to apply to both Output and Input. |
Author
|
I agree this could be done better, but I didn't have much luck splitting the logic tied to the single overamplicfication_key to each tab. editIdeas:
|
disappeared at some point possibly in 520b4db
Author
While (1) still feels a bit out of place, (2) has sane placement and logic for users but is a larger change with likely unneeded code duplication. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disappeared at some point possibly in 520b4db