Skip to content

fix: use WINDOWS_EXPORT_ALL_SYMBOLS and fix DLL install path on Windows - #581

Open
kt286 wants to merge 1 commit into
linuxdeepin:masterfrom
kt286:fix/windows-cmake
Open

fix: use WINDOWS_EXPORT_ALL_SYMBOLS and fix DLL install path on Windows#581
kt286 wants to merge 1 commit into
linuxdeepin:masterfrom
kt286:fix/windows-cmake

Conversation

@kt286

@kt286 kt286 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Add WINDOWS_EXPORT_ALL_SYMBOLS ON to the library target properties, enabling automatic symbol export on Windows without needing compiler-specific linker flags.

Also split the install(TARGETS) command into per-component destinations (LIBRARY, ARCHIVE, RUNTIME) so that DLL files are installed to the bin directory on Windows, which is required by the Windows runtime loader.

fix: 在 Windows 上使用 WINDOWS_EXPORT_ALL_SYMBOLS 并修复 DLL 安装路径

为库 target 添加 WINDOWS_EXPORT_ALL_SYMBOLS ON 属性,在 Windows 上自动 导出符号,无需使用编译器特定的链接器标志。

同时将 install(TARGETS) 拆分为按组件指定安装目录(LIBRARY、ARCHIVE、 RUNTIME),使 DLL 文件在 Windows 上安装到 bin 目录,符合 Windows 运行时 加载器的要求。

Summary by Sourcery

Configure Windows library symbol exports and install runtime DLLs to the appropriate binary directory.

Bug Fixes:

  • Install Windows DLL runtime files to the binary installation directory so they can be located by the Windows runtime loader.

Enhancements:

  • Enable automatic symbol exporting for the library on Windows through its CMake target configuration.

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

Hi @kt286. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai

sourcery-ai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR adjusts the CMake configuration for the core library to correctly export symbols on Windows and to install built DLLs into the appropriate runtime (bin) directory by splitting target installation per component.

File-Level Changes

Change Details Files
Update CMake install and target configuration so Windows builds automatically export symbols and place DLLs in the correct runtime directory.
  • Modify the install(TARGETS) invocation to specify separate destinations for LIBRARY, ARCHIVE, and RUNTIME artifacts.
  • Set the RUNTIME destination to CMAKE_INSTALL_BINDIR so Windows DLLs are installed to the bin directory instead of the library directory.
  • Keep the library and archive outputs installed to the existing library install directory to preserve non-Windows behavior.
src/CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider wrapping WINDOWS_EXPORT_ALL_SYMBOLS ON in a Windows-only condition (e.g., if(WIN32)) to avoid applying this property on non-Windows platforms where it has no effect or could be confusing.
  • If ${LIB_NAME} can be built as a static library, you may want to guard WINDOWS_EXPORT_ALL_SYMBOLS with a check for a shared library target to avoid unexpected behavior or warnings in static builds.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider wrapping `WINDOWS_EXPORT_ALL_SYMBOLS ON` in a Windows-only condition (e.g., `if(WIN32)`) to avoid applying this property on non-Windows platforms where it has no effect or could be confusing.
- If `${LIB_NAME}` can be built as a static library, you may want to guard `WINDOWS_EXPORT_ALL_SYMBOLS` with a check for a shared library target to avoid unexpected behavior or warnings in static builds.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@kt286
kt286 force-pushed the fix/windows-cmake branch from c39d551 to 3b4bce6 Compare August 20, 2026 06:12
@kt286
kt286 marked this pull request as draft August 20, 2026 06:17
BLumia
BLumia previously approved these changes Aug 20, 2026

@BLumia BLumia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Separate install destinations for LIBRARY, ARCHIVE and RUNTIME to ensure
DLL files are installed to the bin directory on Windows instead of lib.

fix: Windows 平台 DLL 安装到 bin 目录

分离 LIBRARY、ARCHIVE 和 RUNTIME 的安装路径,确保 Windows 平台的 DLL
文件安装到 bin 目录而非 lib 目录。
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kt286

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kt286

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kt286
kt286 marked this pull request as ready for review August 20, 2026 12:55

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • If the intent is to move DLLs only on Windows, consider wrapping the RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} change in a WIN32 or platform-specific condition to avoid altering install layouts on other platforms.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- If the intent is to move DLLs only on Windows, consider wrapping the `RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}` change in a `WIN32` or platform-specific condition to avoid altering install layouts on other platforms.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants