cmake: use 'LINKER:SHELL:' prefix for detecting version script support#15844
Merged
slouken merged 1 commit intoJun 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
LINKER:SHELL:prefix for adding the version script.This will automatically use switch between
-Wl,and-Xlinkerfor gcc and clang.This does not fix commas in paths as mentioned in #14384 though.
I don't think this is fixable in global.
Look at the doc page of
CMAKE_LANG_LINKER_WRAPPER_FLAG: the SunPro toolchain only supports a comma as separator.So don't use comma's in your build paths :)
Description
Existing Issue(s)
Fixes #14384 (by using
-Xlinkerfor clang and-Wl,for gcc)