added pt locale - #1017
added pt locale#1017
Conversation
|
Thanks for doing this. I have to be straight about the order: #594 was assigned to @biancamp85 on 19 Sep, before this PR opened. I said on the issue that I do not take a claim back after 24 hours, and I am not making an exception here, because the lesson that leaves is that racing pays. So I am leaving this open rather than closing it: if her translation does not arrive, or she steps back, yours is next. In the meantime the most useful thing you could do is review her PR when it opens, since you have already been through every line of this file yourself. One note so it does not look like something failed: the required checks have not run here yet, they need maintainer approval for a first-time contributor. Nothing is red, it is unmeasured. |
|
Hi @paulocoutinhox and @cevheri, The translation structure looks good and keeps the right scope from the other localized READMEs. I spotted a few literal translations that sound unnatural in Brazilian Portuguese and should be adjusted before merging:
The database tables, code blocks, and the plain-HTTP security warning look consistent with the main README. |
|
Fixed. |
|
@paulocoutinhox a heads-up so this is ready when #594 is decided on 29 September. Against current main, |
071bfbf to
f95ea6a
Compare
|
done |
f95ea6a to
2185cf6
Compare
Apache Kafka reached the localized READMEs in libredb#1123 and Trino is called by its own name since 42be4c0, both after this branch was cut. Mirror them the way README_es.md has them: eighteen engines in the heading and the list, the Trino and Kafka rows, and the two Kafka clauses of the transport paragraph.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Merged, thank you @paulocoutinhox, and thanks for your patience. main had moved again, so I merged it in and synced the Kafka and Trino rows (14c8ada). @Roberton003 thank you for the review. |
The Brazilian Portuguese README (libredb#1017) landed on main first and touched the same language-switcher line in every README and the LOCALIZED list in scripts/readme-check.mjs. Both languages are kept, Portuguese before Russian in merge order, and Biome now wraps the seven-entry LOCALIZED array.
… pt where ru is listed Each README's switcher lists every other language, so README_pt.md gains Русский and README_ru.md gains Português (Brasil). libredb#1017 did not add README_pt.md to CONTRIBUTING.md or docs/ADDING_A_PROVIDER.md, while this PR adds README_ru.md there, so both now name it and the checklist counts seven translations, matching LOCALIZED.
Adds README_ru.md, abridged like the other translations, links it from every README's language switcher, and adds it to the readme:check drift guard and the published-credentials test. Merged with main after the Brazilian Portuguese README (#1017): both languages are kept in every switcher, README_pt.md and README_ru.md link to each other, and CONTRIBUTING.md and docs/ADDING_A_PROVIDER.md list both. Closes #610
Description
Type of Change
Related Issue
Closes #
Changes Made
Testing
Test Environment
Screenshots (if applicable)
Checklist
bun run test:coverageandbun run coverage:check)src/lib/db/providers/, I updated the matchingdocs/providers/documentation andtests/integration/db/tests in the same PR (provider triad)Additional Notes