Move code from ufunc.c.templ to erfa_generator.py#279
Merged
avalentino merged 1 commit intoJun 25, 2026
Conversation
The new Python code helps avoid code repetition in the `erfa/ufunc.c` template. Furthermore, Python code can be checked with tools such as Ruff or Mypy and there is better IDE support.
eerovaher
commented
Jun 25, 2026
Comment on lines
-236
to
+233
| if (copy_{{ arg.name }}) { | ||
| {{ arg.copy_elements("to") }} | ||
| } | ||
| {{ arg.cast_pointer_if_needed | indent(8) }} | ||
| else { | ||
| {{ arg.cast_pointer }} | ||
| {{ arg.copy_elements("to") }} |
Contributor
Author
There was a problem hiding this comment.
I've changed the order of the branches here, which does introduce differences in the generated C code, but there should be no changes in what the code does.
eerovaher
commented
Jun 25, 2026
Comment on lines
+205
to
+213
| @functools.cached_property | ||
| def cast_pointer_if_needed(self) -> str: | ||
| return "\n".join( | ||
| [ | ||
| f"if (!copy_{self.name}) {{", | ||
| f" {self.cast_pointer}", | ||
| "}", | ||
| ] | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
I've been formatting the code I touch (including this function) using the Ruff formatter with its default style. With the preview style this function would look better:
@functools.cached_property
def cast_pointer_if_needed(self) -> str:
return "\n".join([
f"if (!copy_{self.name}) {{",
f" {self.cast_pointer}",
"}",
])If we can agree that we like the preview style more then I could turn that on.
avalentino
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new Python code helps avoid code repetition in the
erfa/ufunc.ctemplate. Furthermore, Python code can be checked with tools such as Ruff or Mypy and there is better IDE support. If we keep moving code from the templates toerfa_generator.pythen it might eventually become possible to dropjinja2as a build requirement.