Implement the Argument.memcpy_if_needed property#278
Merged
Conversation
Implementing the property allows moving code from the `erfa/ufunc.c` template to `erfa_generator.py`, where it can be checked with tools such as Ruff or Mypy. Furthermore, the `Argument.size` property is no longer needed.
avalentino
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general replacing code in the templates with code in
erfa_generator.pyallows reducing code duplication, and Python code can be checked with tools such as Ruff or Mypy. In this particular case there is an additional benefit because implementingArgument.memcpy_if_neededallowsArgument.sizeto be removed.