Repository navigation
fix(models): support GPT-5.4 xhigh reasoning effort - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatOpenAI()duplicatereasoning_effortkeyword collision when config defaults and runtime overrides are both presentreasoning_effortprecedence only when DeerFlow actually injects that fallbackxhighsupport across frontend types, workspace selection, and request payload derivationVerification
cd backend && make lintcd backend && uv run pytest tests/test_model_factory.py -k 'reasoning_effort or duplicate' -vcd frontend && pnpm test tests/unit/core/threads/reasoning-effort.test.tscd frontend && pnpm check(passes with 3 pre-existing warnings inmessage-list-item.tsx/message-list.tsxunrelated to this PR)bash -lc 'export NVM_DIR="$HOME/.nvm"; . "/opt/homebrew/opt/nvm/nvm.sh"; nvm use 22 >/dev/null; cd frontend && pnpm build'cd backend && uv run python - <<'PY' ... create_chat_model(name="gpt-5.4", thinking_enabled=True, reasoning_effort="high") ... PY(returnsOKinstead of raising duplicate keywordTypeError)$review against main(Standards: no hard findings; Spec: no hard findings)Closes #12.