Skip to content

fix(models): support GPT-5.4 xhigh reasoning effort - #14

Merged
lgxyc merged 3 commits into
mainfrom
feature/12-gpt54-xhigh-reasoning-effort
Jul 1, 2026
Merged

lgxyc merged 3 commits into
mainfrom
feature/12-gpt54-xhigh-reasoning-effort

Conversation

@lgxyc

@lgxyc lgxyc commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • fix the ChatOpenAI() duplicate reasoning_effort keyword collision when config defaults and runtime overrides are both present
  • preserve forced disable-path reasoning_effort precedence only when DeerFlow actually injects that fallback
  • add explicit xhigh support across frontend types, workspace selection, and request payload derivation
  • add regression coverage for backend merge behavior and frontend request/default reasoning-effort semantics
  • add a repo-level AGENTS documentation-layering rule requested during implementation

Verification

  • cd backend && make lint
  • cd backend && uv run pytest tests/test_model_factory.py -k 'reasoning_effort or duplicate' -v
  • cd frontend && pnpm test tests/unit/core/threads/reasoning-effort.test.ts
  • cd frontend && pnpm check (passes with 3 pre-existing warnings in message-list-item.tsx / message-list.tsx unrelated to this PR)
  • bash -lc 'export NVM_DIR="$HOME/.nvm"; . "/opt/homebrew/opt/nvm/nvm.sh"; nvm use 22 >/dev/null; cd frontend && pnpm build'
  • cd backend && uv run python - <<'PY' ... create_chat_model(name="gpt-5.4", thinking_enabled=True, reasoning_effort="high") ... PY (returns OK instead of raising duplicate keyword TypeError)
  • $review against main (Standards: no hard findings; Spec: no hard findings)

Closes #12.

@github-actions github-actions Bot added area:backend Gateway / runtime / core backend under backend/ area:docs Documentation and Markdown only area:frontend Next.js frontend under frontend/ needs-validation Touches front/back contract surface; needs real-path validation risk:medium Medium risk: regular code changes size/L PR changes 300-700 lines labels Jun 30, 2026
@lgxyc
lgxyc merged commit ded7d23 into main Jul 1, 2026
11 checks passed
@lgxyc
lgxyc deleted the feature/12-gpt54-xhigh-reasoning-effort branch July 1, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:backend Gateway / runtime / core backend under backend/ area:docs Documentation and Markdown only area:frontend Next.js frontend under frontend/ needs-validation Touches front/back contract surface; needs real-path validation risk:medium Medium risk: regular code changes size/L PR changes 300-700 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix duplicate reasoning_effort kwargs for GPT-5.4 xhigh runs

1 participant