Makefile: lower the non-k rootfs ceiling to 290MB - #6489
Merged
Conversation
The generic x86_64 and arm64 rootfs builds to 273.4 MiB (286,691,328 bytes) on amd64, so a 290MB ceiling clears the current baseline with 16.6 MiB to spare while catching a size regression one megabyte sooner. The value is MiB despite the name -- the check multiplies it by 1024*1024 -- so 290 is 304,087,040 bytes, still under the 300MB pre-10.2.0 partition limit the comment above it describes. Signed-off-by: eriknordmark <erik@zededa.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6489 +/- ##
==========================================
+ Coverage 25.94% 26.27% +0.32%
==========================================
Files 513 523 +10
Lines 94155 95871 +1716
==========================================
+ Hits 24432 25189 +757
- Misses 67841 68616 +775
- Partials 1882 2066 +184 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rene
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One of my PRs I merged today had the non-k rootfs size guard sits at 291MB since that was needed last week.
Reverting that change since it is no longer needed.
How to test and validate this PR
N/A
Changelog notes
No user-facing changes.
PR Backports
Checklist
number is updated in the same hunk; there is no separate doc for this guard.
make rootfson amd64.a build-time size assertion, so CI's arm64 rootfs build covers it.
stablelabel, since nobackport is requested.