chore: bump VERSION to 2.8.0 - #20
Merged
Merged
Conversation
The constant is sent as the User-Agent on every request (Client.php:58), so leaving it at 2.7.0 would make every 2.8.0 install report the wrong version in API logs. VERSIONING.md lists this as a release step; the assertion in LettrTest is what catches it being missed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release step from
VERSIONING.md:65, missed in #19.Lettr::VERSIONis sent as theUser-Agenton every request (Client.php:58). Left at2.7.0, every 2.8.0 install would report the wrong version — including in Lettr's own API logs, where requests are bucketed by SDK version.tests/Unit/LettrTest.php:196asserts the constant, which is what catches this; it moves with it.Two lines. 303 tests pass.
After this merges, the remaining release steps are
git tag -a v2.8.0andgit push origin main --tags.🤖 Generated with Claude Code