Repository navigation
fix: accept inbound attachments without filenames - #40
Merged
Merged
Conversation
bjarn
enabled auto-merge (squash)
September 27, 2026 13:11
Bjornftw
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An inbound email with an unnamed attachment currently causes HTTP 500 before the webhook event can be dispatched. This blocked a support reply and all 12 delivery attempts.
Accept null or absent attachment filenames and use
attachment.emlfor attached emails (message/rfc822), orattachmentfor other content types. Preserve supplied filenames and attachment content. This also lets consumers process stored payloads that contain null filenames after they install the fixed SDK.Validation: all 87 SDK tests pass (400 assertions), including signed webhook requests for null, absent, and supplied filenames. Pint and PHPStan pass. The regression tests failed with HTTP 500 before the fix.
A package release and consumer dependency update are required to apply this SDK fix. No release or production replay is included.
Related platform PR: https://github.com/lettermint/lettermint/pull/2523.