feat: allow disabling automatic webhook route registration - #35
Merged
Merged
Conversation
Add a backward-compatible webhooks.enabled config flag (default true) so apps can skip the package webhook route and register WebhookController with VerifyWebhookSignature themselves. Fixes #33 Co-authored-by: Bjarn Bronsveld <bjarn@users.noreply.github.com>
bjarn
marked this pull request as ready for review
August 28, 2026 07:24
Bjornftw
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33.
The package always registered
POST /{prefix}/webhookvia SpatiehasRoute('webhooks')inconfigurePackage, with no way to opt out. That hook also runs before package config is merged, so a config flag cannot be read there.Change
webhooks.enabled(env:LETTERMINT_WEBHOOK_ENABLED, defaulttrue) so existing apps keep the auto-registered routebootingPackage()only when that flag is true (after config merge, before Spatie loads routes)WebhookController+VerifyWebhookSignatureyourself (including domain/subdomain grouping)Tests
lettermint.webhook→/{prefix}/webhook)webhooks.enabledisfalsePackage version is unchanged.