Repository navigation
Add sync operations and filter utilities for classroom partitioning - #14070
Conversation
github-actions
Bot
added
DEV: backend
bjester
changed the title
Build Artifacts
|
93088c5 to
fdbd607
Compare
bjester
changed the title
fdbd607 to
a4e4554
Compare
bjester
added
TODO: needs review
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
Just a few non-blocking comments - this all broadly makes sense to me, and we can get complete assurance after we've implemented the course related models, and extended the morango integration tests to include these cases.
| ): | ||
| # receive the modified, dynamic, filter(s) from the server and update the transfer | ||
| # session and context objects to reflect the change | ||
| context.update(sync_filter=response_filter) |
There was a problem hiding this comment.
non-blocking: In Morango should updating the transfer session's filter be automatic upon updating the context as well?
There was a problem hiding this comment.
It's possible but there's currently some cyclic relationships between the two, so I had some concerns about making it automatic. The context is used initially to hold the filter and relay it until the transfer session is created, but it also lets the transfer session take precedence. Deconstructing the consequences of all that was too much to be worthwhile IMO so I didn't try to change anything.
| if collection is None: | ||
| collection = Collection.objects.get(pk=collection_id) | ||
|
|
||
| while collection.kind != collection_kinds.CLASSROOM: |
There was a problem hiding this comment.
In other places we deliberately made the 'collection tree' a fixed structure, rather than able to be arbitrarily nested, so this could be a couple of if statements instead of a while loop - but it would have the same net result.
a4e4554 to
fad881f
Compare
Summary
make docker-whlfor local build of wheel and pex filesmake %-with-postgres(e.g.make test-with-postgres) use ofdocker-composeby updating it to new integrated plugindocker composeCollections, to a classroomReferences
Scope: learningequality/morango#283
Supported by: learningequality/morango#284
Reviewer guidance
INTEGRATION_TEST=1 pytest kolibri/core/auth/test/test_morango_integration.pymake docker-whlto build assetsmake test-with-postgresfor running tests on postgres