Repository navigation
Refresh automation.yml from the shared template - #174
Conversation
🟡 Waiting for changesLast updated: 2026-09-21 15:59 UTC |
rtibblesbot
left a comment
There was a problem hiding this comment.
PR #174 is a pure re-sync of the vendored caller against the shared template. The file is byte-identical to learningequality/.github@main:automation-template.yml. The parsed on: block is semantically unchanged from main once each types list is sorted. CI is passing. No UI files changed, so manual QA did not apply.
- nitpick: the PR body's zizmor and yamlfmt bullets don't describe anything in this repo. The caller this PR replaced had a bare
on:with no zizmor comment. No zizmor config or pre-commit hook exists here either. Byte-identity with the template is the real justification. Please drop those two bullets from the PR description.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
Ran a phased review pipeline over the pull request diff:
- Classified the diff to select review passes (core, frontend, backend) and whether manual QA was required
- Core review pass checked correctness, design, architecture, testing, completeness, and DRY/SRP/Rule-of-Three principles
- Specialized frontend/backend review passes applied framework-specific lenses where those files changed
- For UI changes: manual QA and an accessibility audit against a live dev server, when available
- Checked CI status and linked issue acceptance criteria
- Synthesized one review from those passes and chose the verdict from the findings, CI status, and QA evidence
| - reopened | ||
| - edited | ||
| - review_request_removed | ||
| on: # zizmor: ignore[dangerous-triggers] |
There was a problem hiding this comment.
praise: this refresh is a verifiable no-op. Diffing against the fetched template gives an exact match. Parsing both revisions with each types list sorted compares equal. pull_request_target keeps all 9 types. issues keeps all 6.
The copy of
automation.ymlin this repo predates three fixes inlearningequality/.github. This replaces it with the currentautomation-template.ymlfrommain.name:is removed. yamlfmt v0.16.0 and later strip it, so a repo on a newer pin rewrites the file on its next pre-commit run.on:carries# zizmor: ignore[dangerous-triggers]. zizmor reportspull_request_targetas a dangerous trigger, and the callers this template replaced each carried the same inline ignore.No trigger changes. The event and activity type sets are identical, so every automation fires exactly as it does today.