Skip to content
This repository was archived by the owner on Oct 6, 2026. It is now read-only.
This repository was archived by the owner on Oct 6, 2026. It is now read-only.

Remove /etc/default/kolibri #85

Closed as not planned
Closed as not planned

Description

@benjaoming

Discussed with @jredrejo

We might not be benefiting from /etc/default/kolibri at all - the code can be moved to /etc/init.d/kolibri which initially sources it.

  1. This will reduce a layer
  2. This will also reduce a "configuration madness" vector: We don't encourage anyone to put configuration in /etc/default/kolibri, but we still risk that they'll go and do it anyways :)

I wrongfully discouraged using this file, as I have seen it change during .deb upgrades. But actually in the background info I can find on this location, people actually wanted this directory to discourage editing of the init.d scripts themselves :)

https://askubuntu.com/questions/429592/what-is-the-purpose-of-etc-default

Activity

  1. benjaoming commented on Nov 15, 2019

    @benjaoming
    ContributorAuthor

    I'm +1 or +0 for this change, unless someone has an objection :)

  2. jredrejo commented on Nov 15, 2019

    @jredrejo
    Contributor

    I think that KOLIBRI_HOME and KOLIBRI_USER variables from /etc/default/kolibri are useful (they are reused in the kolibri-server init script). The rest of the file is not needed from my pov.

    If we delete this file, kolibri-server would use the same function to calculate KOLIBRI_HOME, what's not a big problem, just a bit of code duplication.

  3. benjaoming commented on Nov 15, 2019

    @benjaoming
    ContributorAuthor

    Am not suggesting to delete the contents. I would just move those contents unchanged to /etc/init.d/kolibri

    Everything that can be configured for Kolibri should be configured somewhere that is genuinely owned by the system administrator and not overwritten by package updates. We should not encourage to hack files that are maintained by the package, that's why we have /etc/kolibri

    /etc/default/kolibri has the logic that loads /etc/kolibri - so removing that would contradict the whole current design, which is documented and used.

  4. benjaoming commented on Nov 15, 2019

    @benjaoming
    ContributorAuthor

    Hmm, I can see the point of sourcing /etc/default/kolibri in kolibri-server

  5. benjaoming commented on Nov 15, 2019

    @benjaoming
    ContributorAuthor

    Maybe let's just freeze this for later, it's not in order to fix any real issues

  6. rtibbles commented on Oct 4, 2026

    @rtibbles
    Member

    Closing as stale ahead of archiving this repository. The Debian package now lives in the Kolibri monorepo; please open a fresh issue on learningequality/kolibri if this is still wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions