Skip to content

CI runs the example app's tests #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KamilSztandur merged 1 commit into from
Sep 28, 2026
Merged

CI runs the example app's tests #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ jobs:
- name: Run tests
run: flutter test

- name: Run the example app's tests
run: flutter test
working-directory: example
Comment on lines +49 to +51

@PiotrRogulski PiotrRogulski Sep 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, since these tests are load-bearing, I feel like they should be moved to the package's own test directory, and not sit in examples

@KamilSztandur KamilSztandur Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behaviour test is in the package already. These are the example app's own tests, they import its screens, so they can't be moved outside. This step just keeps the example app from rotting like it's happening currently


- name: Dry run pub publish
# We don't want it to fail the CI, it's just to see how would `pub publish` behave.
run: dart pub publish --dry-run || true
Expand Down
Loading