Repository navigation
fix(docker): load bundled vector store connection defaults - #45407
Merged
Merged
Conversation
Load the selected provider defaults for API, workers, and Beat, preserving root and provider overrides. Align bundled connection credentials and internal networks, and keep the Agent local sandbox token exclusively in the root deployment inputs. Clarify Code sandbox credential and network requirements.
Map Qdrant API keys and PostgreSQL initialization usernames to the image-native variables so copied provider settings configure both clients and servers. Preserve existing client overrides and scope credential-rotation guidance to stored database passwords.
github-actions
Bot
added
the
size:XL
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45407 +/- ##
========================================
Coverage 89.80% 89.80%
========================================
Files 6239 6240 +1
Lines 390966 391117 +151
Branches 79305 79329 +24
========================================
+ Hits 351091 351239 +148
- Misses 33779 33782 +3
Partials 6096 6096
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Document the complete MySQL connection settings, root override boundaries, middleware template destination, and matching Weaviate authentication inputs. Cover separate sandbox credentials, legacy Agent names, middleware loading, and root precedence in isolated Compose regressions.
Keep the usual .env.example naming rule explicit and identify middleware.env as the separate destination for the development stack.
Point the startup template to the documented loading rules instead of promising root precedence for unmapped native service variables.
laipz8200
marked this pull request as ready for review
November 3, 2026 09:09
laipz8200
enabled auto-merge
November 3, 2026 09:10
Enable OpenSearch TLS certificate verification by default for both bundled and external endpoints. Keep explicit opt-outs and root environment precedence, and document the choice required for local demo certificates. Restore unconditional Weaviate REST, gRPC, and API key fallbacks for knowledge bases whose stored backend remains Weaviate after VECTOR_STORE changes. Cover copied defaults, existing override paths, explicit empty values, and root precedence with focused Compose regressions.
fatelei
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #45405.
Selecting a bundled vector store currently starts its server without supplying the corresponding client connection defaults to the API and workers. Load the selected provider's
.defaultsfor the API, workers, and Beat, including the Elasticsearch Japanese variant. Keep root.envprecedence and existing provider,api-worker.env, andshared.envoverrides.Supply the bundled endpoints and credentials, align Qdrant and PostgreSQL image-native credential mappings, and make Milvus and OpenSearch reachable from the API's Compose network. Convert the Milvus, MyScale, MatrixOne, and Vastbase templates to
.defaultswhile preserving their existing.envoverride paths.Keep the user-generated Agent local sandbox token exclusively in root deployment inputs and pass it consistently to both services. Root
.env.exampleremains minimal. Clarify the matching Code sandbox credentials and the networking requirement in the Docker README and configuration comments.Documentation: langgenius/dify-docs#1171.
Checklist