Repository navigation
docs: fix the skill draft-hash order and stop weaviate gracefully before backup - #1176
Merged
Merged
Conversation
After draft_changed, read the new draft_hash with describe skill before exporting and merging, then import with that saved hash. Reading it after the merge could pick up a later edit and overwrite it.
Stop the deployment with docker compose stop -t -1, so Compose doesn't force Weaviate down after its 10-second default and lose data.
Ill-donut
approved these changes
Nov 4, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The review identifies no active issues with the documentation updates for draft-hash recovery and graceful pre-backup shutdowns.
No open issues 🎉
What changed in this PR
Updates English, Chinese, and Japanese documentation to address two safety issues identified in #1174: concurrent skill edits during imports and forced Weaviate shutdowns before backups.
Changes:
- Clarifies that users must save
draft_hashbefore exporting and merging a skill draft, then import with that saved hash. - Changes the pre-backup shutdown command to
docker compose stop -t -1and explains that shutdown may take time.
| File | Description |
|---|---|
zh/self-host/deploy/quick-start/docker-compose.mdx |
Updates Chinese backup instructions to wait for graceful shutdown. |
zh/cli/reference/results-errors-and-exit-codes.mdx |
Corrects the draft-hash recovery sequence in Chinese. |
ja/self-host/deploy/quick-start/docker-compose.mdx |
Updates Japanese backup instructions to wait for graceful shutdown. |
ja/cli/reference/results-errors-and-exit-codes.mdx |
Corrects the draft-hash recovery sequence in Japanese. |
en/self-host/deploy/quick-start/docker-compose.mdx |
Updates English backup instructions to wait for graceful shutdown. |
en/cli/reference/results-errors-and-exit-codes.mdx |
Corrects the draft-hash recovery sequence in English. |
Review effort: Balanced
RiskeyL
added a commit
that referenced
this pull request
Nov 4, 2026
* docs: rename the agent knowledge section to Knowledge Retrieval in the glossary (#1172) * docs: sync self-host docs for ce 1.19.0 (#1170) * docs: add knowledge retrieval to the self-host agent build page * fix: describe the structured output fallback on the self-host llm page * docs: cover workflows bundled in app packages for 1.19.0 * docs: document the ops_trace_v2 queue and trace delivery settings * docs: add the gunicorn keep-alive variable * docs: add the plugin daemon uv cache directory variable * docs: update service api error codes and parameters for 1.19.0 * docs: add workspace skill commands to the cli reference * docs: list what disabling the marketplace hides in the console * docs: note the one-second limit of the skill import draft hash * docs: describe the skill import draft hash as a guard, not a guarantee * docs: shorten the skill package limit row in cli troubleshooting * docs: say which versions can import an app package exported from 1.19.0 * docs: note that include_all no longer filters the knowledge base list * docs: drop the outdated agents switch cause from the agent build page * Revert "docs: drop the outdated agents switch cause from the agent build page" This reverts commit f0e2252. dify-docs#1171 rewrites the same accordion for the new Docker configuration layout. * docs: allow null workflow inputs in the service api schema * docs: update cli stop run and get run event for run ids (#1146) * docs: update cli stop run and get run event for run ids * docs: say how to tell a stopped run or reply in cli stop docs * docs: correct the cli stop run docs against the 1.19.0 code * docs: restructure the cli stop sections to match the run apps page * docs: keep one example of a destructive command label * docs: split the incomplete and failed result bullets * docs: check the run state before handling run_not_stoppable * docs: limit the run_not_stoppable workaround to paused runs --------- Co-authored-by: RiskeyL <7a8y@163.com> * docs: name the plugin daemon version the 1.19.0 compose file ships (#1173) * docs: describe docker setup and configuration (#1171) * docs: align docker configuration and upgrade guidance Update the Docker Compose, environment-variable, and Dify Premium pages in English, Chinese, and Japanese for the categorized defaults layout in langgenius/dify#45359. Explain root and service override precedence, shared credential placement, mapped inputs, and Docker Compose requirements. Preserve working configuration during upgrades and identify values that now become effective. * docs: align shared defaults and code node configuration Point sandbox and Code node customization to the current defaults templates in English, Chinese, and Japanese. Explain copying new overrides, editing existing files, and uncommenting optional assignments. Document preserved shared.env paths and cleanup of accidental empty Celery worker overrides when upgrading to the consolidated shared defaults. * docs: describe current docker configuration workflow Clarify Docker Compose setup, optional service overrides, precedence, and configuration application across English, Chinese, and Japanese guides. Use current-state explanations and a complete Nginx customization example. Correct secret-key persistence, sandbox behavior, Code limits, WebSocket setup, and bundled credential defaults. Preserve upgrade guidance for local overrides, persistent storage, and the agent's named volumes. Remove the AWS AMI additions from this PR because its packaging is not established by the companion Docker configuration change. * docs: name api and worker configuration files explicitly Update Docker setup and environment references in English, Chinese, and Japanese to use api-worker.defaults and api-worker.env. Explain continued shared.env support and the precedence of the new file, and retain upgrade instructions for both existing and new override paths. * docs: correct premium upgrades and agent visibility guidance Update the Premium deployment guide in English, Chinese, and Japanese to use the current defaults templates and Docker Compose 2.35.0. Upgrade from a selected release while preserving local environment files, AWS Compose overrides, secrets, and persistent data. Replace outdated Agent template-sync advice with explicit override checks and web container recreation. Document the unset and empty true fallback from web.defaults, root precedence, and current navigation visibility. * docs: align bundled vector stores and sandbox configuration Describe automatic bundled provider defaults and preserve the existing override workflow in English, Chinese, and Japanese. Clarify root Agent sandbox token placement, matching Code sandbox credentials, and architecture-independent network request restrictions. * docs: clarify docker configuration and backup behavior Describe complete MySQL inputs, shared credential pairs, root override boundaries, middleware paths, and legacy variable replacements. Identify actual sandbox backup volumes and explain Code sandbox network reachability in English, Chinese, and Japanese. * docs: refine translated configuration instructions Clarify provider selection, optional template copying, unchanged container mappings, and preservation of configured or stored keys without altering the English guidance. * docs: preserve middleware config in weaviate commands Load middleware.env explicitly when managing Weaviate in the source-development stack. Document the Compose file and project options before the first command, and retain the existing project name across upgrades. Keep the English, Chinese, and Japanese migration instructions aligned. * docs: explain secure vector store upgrades Document OpenSearch certificate verification as enabled by default, require an explicit local demo-certificate opt-out, and explain that saved false overrides survive an upgrade. Preserve connections and Compose profiles for existing vector backends when choosing a new default. Explain legacy Weaviate fallbacks and continued provider override loading, with matching English, Chinese, and Japanese guidance. * docs: restructure the docker compose quick start Keep the first run to three steps and a sign-in, and give production hardening its own Secure the Deployment section. Cut Customize down to where settings go, how to apply them, and the Nginx worked example, and point to Environment Variables for vector stores, databases, and precedence. Keep Upgrade version-independent: back up (stop first, include named volumes), check out, review configuration, apply. Translate the restructured page into Chinese and Japanese. * docs: rewrite configuration files guidance and tighten env var sections Rewrite Configuration Files around finding the file for a variable, editing it, and applying the change, with a precedence order per service type. Say each rule once: drop the repeated precedence, keep-in-use, and sandbox-key reminders from the variable sections. Correct facts found in review: VECTOR_STORE switching steps (copy a non-Weaviate provider's defaults before switching, OceanBase and seekdb share settings), tidb_vector, client credentials that follow the bundled server settings, OpenSearch AWS defaults, Sentry inputs versus container variables, the agent stub URL exposure, and the DB_PLUGIN_DATABASE row's section. Drop shared.env notes, which move to the release notes. Carry the changes into Chinese and Japanese. * docs: restore the workspace role note in agent troubleshooting --------- Co-authored-by: RiskeyL <7a8y@163.com> * docs: fix the skill draft-hash order and stop weaviate gracefully before backup (#1176) * docs: read the skill draft hash before merging an export After draft_changed, read the new draft_hash with describe skill before exporting and merging, then import with that saved hash. Reading it after the merge could pick up a later edit and overwrite it. * docs: stop weaviate gracefully before an upgrade backup Stop the deployment with docker compose stop -t -1, so Compose doesn't force Weaviate down after its 10-second default and lose data. --------- Co-authored-by: Stephen Zhou <hi@hyoban.cc> Co-authored-by: Xiyuan Chen <52963600+GareArc@users.noreply.github.com> Co-authored-by: -LAN- <laipz8200@outlook.com>
RiskeyL
added a commit
that referenced
this pull request
Nov 4, 2026
…ts (#1178) * fix: document the chunk_overlap minimum in the service api spec dify#45455 set a minimum of 0 on chunk_overlap. The Create Document by Text and Update Document by Text request schemas now state it. en, zh, and ja. * docs: document show_thoughts in the get app parameters response dify#45427 added show_thoughts to GET /parameters. It reports the published Agent's Show thinking setting and is false for other app types; agent_thought events carry the thinking either way. Schema and response example, en, zh, and ja. * docs: add show thinking to the self-host app toolkit New Show Thinking section for the new Agent's Chat Features (dify#45427), checked in Build mode because Community Edition has no Preview. The intro names Chat Features for an Agent, and the first caption now says Legacy Agents. en, zh, and ja. * fix: correct the code node limits, sandbox note, and retry label The Note states the SANDBOX_ENABLE_NETWORK requirement and the error when it's off. Output Limits lists each default with its variable, scopes array limits to array outputs, and explains object depth. Security Considerations says what sandbox code can reach. Retry Settings becomes the UI's Retry on failure. en, zh, and ja. * fix: restore the plain stop command before the upgrade backup docker compose stop -t -1 waits forever on services that ignore SIGTERM (sandbox and the SSRF proxies), so the upgrade hung at the backup step. Back to docker compose stop, as before #1176. en, zh, and ja. * fix: tighten the environment variables reference for 1.19.0 Set a Variable's Find the File step now decides docker/.env versus a local file first, then lists what to do for each search result, including variables several .defaults files share. Rows and leads follow the env-vars rule pack: rename clauses, removed OPS_TRACE settings dropped, consequences stated (OPS_TRACE_QUEUE, ENABLE_TRACE_PAYLOAD_SWEEP_TASK, COMPOSE_PROFILES, MILVUS_ENABLE_HYBRID_SEARCH, OpenSearch AWS auth), single-service settings pointed at their local files. Adds the Qdrant Service accordion, the OpenSearch ulimit note, and the 1.19.0 OpenShell link. en, zh, and ja. * fix: align the dify premium configuration and upgrade with 1.19.0 Configuration points to Set a Variable and keeps one example; Apply Changes says what to check when a change doesn't take effect. Upgrade backs up after stopping the deployment, reviews local files against the new templates, and flags the local sandbox token in a Note. en, zh, and ja.
RiskeyL
added a commit
that referenced
this pull request
Nov 4, 2026
…ts (#1178) (#1179) * fix: document the chunk_overlap minimum in the service api spec dify#45455 set a minimum of 0 on chunk_overlap. The Create Document by Text and Update Document by Text request schemas now state it. en, zh, and ja. * docs: document show_thoughts in the get app parameters response dify#45427 added show_thoughts to GET /parameters. It reports the published Agent's Show thinking setting and is false for other app types; agent_thought events carry the thinking either way. Schema and response example, en, zh, and ja. * docs: add show thinking to the self-host app toolkit New Show Thinking section for the new Agent's Chat Features (dify#45427), checked in Build mode because Community Edition has no Preview. The intro names Chat Features for an Agent, and the first caption now says Legacy Agents. en, zh, and ja. * fix: correct the code node limits, sandbox note, and retry label The Note states the SANDBOX_ENABLE_NETWORK requirement and the error when it's off. Output Limits lists each default with its variable, scopes array limits to array outputs, and explains object depth. Security Considerations says what sandbox code can reach. Retry Settings becomes the UI's Retry on failure. en, zh, and ja. * fix: restore the plain stop command before the upgrade backup docker compose stop -t -1 waits forever on services that ignore SIGTERM (sandbox and the SSRF proxies), so the upgrade hung at the backup step. Back to docker compose stop, as before #1176. en, zh, and ja. * fix: tighten the environment variables reference for 1.19.0 Set a Variable's Find the File step now decides docker/.env versus a local file first, then lists what to do for each search result, including variables several .defaults files share. Rows and leads follow the env-vars rule pack: rename clauses, removed OPS_TRACE settings dropped, consequences stated (OPS_TRACE_QUEUE, ENABLE_TRACE_PAYLOAD_SWEEP_TASK, COMPOSE_PROFILES, MILVUS_ENABLE_HYBRID_SEARCH, OpenSearch AWS auth), single-service settings pointed at their local files. Adds the Qdrant Service accordion, the OpenSearch ulimit note, and the 1.19.0 OpenShell link. en, zh, and ja. * fix: align the dify premium configuration and upgrade with 1.19.0 Configuration points to Set a Variable and keeps one example; Apply Changes says what to check when a change doesn't take effect. Upgrade backs up after stopping the deployment, reviews local files against the new templates, and flags the local sandbox token in a Note. en, zh, and ja. (cherry picked from commit bb0934f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from Copilot's review of #1174, in en, zh, and ja.
draft_changedrow: read the newdraft_hashwithdescribe skillbefore exporting and merging, then import with that saved hash. Reading the hash after the merge could pick up a teammate's later edit and overwrite it.docker compose stop -t -1. Without-t -1, Compose forces Weaviate down after its 10-second default, which can lose data (see Stop Weaviate Gracefully on the Weaviate upgrade page).Verification
describe skillis the only skill operation that returnsdraft_hash;export skillreturns the zip only; import checks the hash against the draft: verified at langgenius/dify@58ec6d6bcf:api/controllers/openapi/skills.py (describe L286–300, export L337–358, import L408–440).stop_grace_period, so Compose's 10-second default applies: verified at langgenius/dify@b7c7b29517:docker/docker-compose-template.yaml.-t -1waiting for shutdown: same usage asweaviate-server-migration-path.mdx; not re-tested for this PR.