Repository navigation
fe: let the settings scroll under a glass header on macOS, as Mail's content does under its toolbar - #262
Merged
Conversation
…content does under its toolbar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings dialog was an opaque box whose body stopped at its header, so nothing could pass under the bands. On macOS the body now fills the dialog and scrolls beneath a frosted header and footer, which share one grid cell with it. Their heights are fixed in em because the body's padding has to clear them, so tabs wrapping onto two rows in a narrow window would cover the top of the content.
The header turned the tables' rounded corners into gaps once it stuck, so
settings-table-stuck.jssquares them while it is stuck. The scrollbar needed a track margin to stop at the bands, which the standard scrollbar properties turn off, so this dialog styles its own and it also replaces the legacy scrollbar macOS draws with a mouse attached.Also, for the same dialog and its siblings:
make e2epassed before the rebase onto main (173 + 40 + 3 scenarios);make qapassed after it, phpstan with its own temp folder, since the shared cache holds a path from another worktree. No scenario covers the reload fix or the glass, which WebKit snapshots do not draw. The Adminer Desktop row's missing preview is #261.