Skip to content

fe: let the settings scroll under a glass header on macOS, as Mail's content does under its toolbar - #262

Merged
landsman merged 1 commit into
mainfrom
fe/settings-glass
Nov 1, 2026
Merged

landsman merged 1 commit into
mainfrom
fe/settings-glass

Conversation

@landsman

@landsman landsman commented Nov 1, 2026

Copy link
Copy Markdown
Owner

The settings dialog was an opaque box whose body stopped at its header, so nothing could pass under the bands. On macOS the body now fills the dialog and scrolls beneath a frosted header and footer, which share one grid cell with it. Their heights are fixed in em because the body's padding has to clear them, so tabs wrapping onto two rows in a narrow window would cover the top of the content.

The header turned the tables' rounded corners into gaps once it stuck, so settings-table-stuck.js squares them while it is stuck. The scrollbar needed a track margin to stop at the bands, which the standard scrollbar properties turn off, so this dialog styles its own and it also replaces the legacy scrollbar macOS draws with a mouse attached.

Also, for the same dialog and its siblings:

  • macOS: the close button is the window's red light, top left, in every modal; every modal dims the page 40%, not 60%; tables, notices and connection cards take a 12px radius.
  • Settings: appearance, language, density and scaling are aligned label and select rows, on every platform, which is why two e2e steps changed; tabs are centred on macOS.
  • Every platform: more padding in every modal's body, and all settings tabs start at one height, where AI access started higher.
  • Reloading a logged-out connection's URL no longer reopens New connection. A failed login still does.

make e2e passed before the rebase onto main (173 + 40 + 3 scenarios); make qa passed after it, phpstan with its own temp folder, since the shared cache holds a path from another worktree. No scenario covers the reload fix or the glass, which WebKit snapshots do not draw. The Adminer Desktop row's missing preview is #261.

@landsman
landsman merged commit d055c34 into main Nov 1, 2026
5 checks passed
@landsman
landsman deleted the fe/settings-glass branch November 1, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant