Repository navigation
devops: move the latte precompile to app/cli, the last build script a release runs from cli/ - #259
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli/latte-precompile.phpis nowDesktop\Cli\Command\LattePrecompile, called through$(CLI)like the other commands.The precompile has to load the packaged copy's classes, because
Desktop\Lattekeys each compiled file by its path relative to theapp/it was loaded from. Sopackage-appnow runs the copy's ownrun.php, as its first step, while that copy still hasapp/cli/and the dev autoload. That means it runs beforecomposer install --no-devrather than after.Old and new order give the same 16 templates under the same file names; the compiled files differ only in the source-path comment and the
.lockhashes.make bundleshipslatte-cache/with those 16 and nocli/.make qaandmake checkpass.make e2eandmake e2e-packagedwere not run, so the packaged app itself has not been started on this change.