Repository navigation
devops: build the windows icon from logo.png, and start moving build scripts into app/cli - #255
Merged
Merged
Conversation
…scripts into app/cli
landsman
temporarily deployed
to
windows-x86_64
October 31, 2026 23:01 — with
GitHub Actions
Inactive
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assets/logo.pngis now the one source of every icon: the build resizes it with GD intobuild.noindex/logo.ico, so the committed.icofrom #254 and itsmake logo-icostep are gone, and a changed logo can no longer leave a stale Windows icon.This is also the first script moved to the new home for build tooling:
app/cli/, namespaceDesktop\Cli\, static methods with a test intests/cli/. It is dev-only autoload andpackage-appremoves the folder, so nothing ships;make distshows noapp/cliand noDesktop\Cliin the packaged autoloader. The rest ofcli/moves later.The Windows frankenphp keeps GD as
ext/php_gd.dll, so the build loads it through an ini file, as it does for openssl. macOS still makes the.icnswithsips, from the same PNG.Stacked on #254.
Tested:
make qa,make check, a mingw cross-compile whose exe lists the seven images and group 32512, and a dispatched build for GD on the Windows runner. Not looked at on Windows yet.