Skip to content

devops: build the windows icon from logo.png, and start moving build scripts into app/cli - #255

Merged
landsman merged 1 commit into
fe/windows-iconfrom
devops/cli-in-app
Oct 31, 2026
Merged

landsman merged 1 commit into
fe/windows-iconfrom
devops/cli-in-app

Conversation

@landsman

Copy link
Copy Markdown
Owner

assets/logo.png is now the one source of every icon: the build resizes it with GD into build.noindex/logo.ico, so the committed .ico from #254 and its make logo-ico step are gone, and a changed logo can no longer leave a stale Windows icon.

This is also the first script moved to the new home for build tooling: app/cli/, namespace Desktop\Cli\, static methods with a test in tests/cli/. It is dev-only autoload and package-app removes the folder, so nothing ships; make dist shows no app/cli and no Desktop\Cli in the packaged autoloader. The rest of cli/ moves later.

The Windows frankenphp keeps GD as ext/php_gd.dll, so the build loads it through an ini file, as it does for openssl. macOS still makes the .icns with sips, from the same PNG.

Stacked on #254.

Tested: make qa, make check, a mingw cross-compile whose exe lists the seven images and group 32512, and a dispatched build for GD on the Windows runner. Not looked at on Windows yet.

@landsman
landsman deployed to linux-x86_64 October 31, 2026 23:01 — with GitHub Actions Active
@landsman
landsman deployed to macos-arm64 October 31, 2026 23:01 — with GitHub Actions Active
@landsman
landsman merged commit 16d92dc into fe/windows-icon Oct 31, 2026
11 checks passed
@landsman
landsman deleted the devops/cli-in-app branch October 31, 2026 23:09

This branch was successfully deployed

2 active and 1 inactive deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant