Repository navigation
devops: move dresscode's config beside vendor, at the root its type rules found nothing and passed - #238
Merged
Conversation
Owner
Author
|
Where this stands, to pick up later. Branch Still to do
Known when running e2e
Decided
|
This was referenced Oct 31, 2026
landsman
force-pushed
the
devops/dresscode-config-beside-vendor
branch
from
October 31, 2026 22:25
e54bfd9 to
a0f019a
Compare
landsman
commented
Oct 31, 2026
landsman
commented
Oct 31, 2026
landsman
left a comment
Owner
Author
There was a problem hiding this comment.
Review of dee190e. One real bug: the type rules run without phpstan.neon (see the comment on Makefile). The rest are smaller. Only the phpstan.neon finding and the bad-file check's cleanup were traced through source; none of this was run.
Two things in the PR text:
- The body calls the
e2e-bridge-gofailures already seen onmain, but the status comment says there were too few runs to tell whether this branch makes them worse (2, 2 and 3 of 40 here, 1 and 1 onmain). The body should say the same. - The status comment's to-do list is out of date: the silent-rule check now exists, and the e2e numbers have changed.
The docblock at cli/dresscode-hook.php:9 still describes --skip-excluded as unconditional.
…ules found nothing and passed
…ipped those files and exited 0
…business in the document root
…hey ran without it and a dropped file passed
… the same as a clean one
landsman
force-pushed
the
devops/dresscode-config-beside-vendor
branch
from
October 31, 2026 23:21
dee190e to
54035b4
Compare
…ints each one twice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
typeAnalysis: phpstananddresscode.neonat the root, a rule that needs types reported nothing and exited 0, even on a child class written to breakupgrading.classes.Override. DressCode counts its own installation,app/, as foreign code unless the config's root lies inside it (RunnerFactory::findForeignPaths), and our code is in there. A minimal project reproduces it.So the config moves to
app/, the key goes on, and#[\Override]is the first rule using it, with its two findings fixed. PHP now refuses a parent that renames a member under us.cli/is now above the config's root, and DressCode does not walk a directory there, socli/dresscode.shnames each file and the hook drops--skip-excludedfor them. Moving it intoapp/would put scripts in the document root. The type rules readphpstan.neononly from that root too, soapp/phpstan.neonincludes the real one.make dresscodedepends onfetch, because without the filesphpstan.neonnames, the types run without that config and only warn.package-appdeletes every.neonfrom what ships.A clean run cannot tell type rules from silence, so
make dresscodealso copiestests/dresscode/override-missing.php, which breaks the rule on purpose, intoapp/andcli/for one run, and fails unless both are reported or ifphpstan.neonwas not read. Checked by breaking each:typeAnalysisremoved, the include broken,app/phpstan.neondeleted.tests/cli/dresscode-test.shcovers the same decisions and an interrupted run's cleanup.The hook now uses the edited worktree's own config and dresscode, so a file there is no longer skipped with exit 0. Where it cannot check, with no
app/vendoror noapp/adminer.php, it says so to the agent. Closes #253.make qapasses on the final commit;make checkpassed just before a last cleanup of the config and script.make e2ewas not rerun after the review fixes, which touch only lint tooling and the dev hook. Before them the main suite passed 173 of 173 ande2e-bridge-gofailed 3 of 40 inmcp.feature. That job also fails onmain, a different scenario each run (here 2, 2 and 3 of 40, onmain1 and 1), too few runs to tell whether this branch makes it worse.